Implement error logging and exception catching in FolderBrowser#2798
Open
ChristosMaragkos wants to merge 4 commits into
Open
Implement error logging and exception catching in FolderBrowser#2798ChristosMaragkos wants to merge 4 commits into
FolderBrowser#2798ChristosMaragkos wants to merge 4 commits into
Conversation
ff344ca to
612d665
Compare
Author
|
I also took the liberty of adding a fake directory when an exception is caught to communicate to the user that an error occured in-game. Will revert if too much. |
Collaborator
|
Did you manage to get any info about your issue from this? Running it should give you the log with the exception now, no? |
Author
|
I wasn't able to because for some reason the game did not fail to scan the directory this time around. Which is a net positive either way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FolderBrowserusesDirectory.GetDirectoriesto scan the filesystem, which can throw for numerous reasons (path too long, any subdirectory failing, etc.). This is fine but, currently, in the event of an error:This PR fixes those issues by:
..directory to the list if an exception is caughtCloses #2796
Be aware that this does not fix any underlying potential issue. It just clearly communicates any errors to the player.