Skip to content

Pin the cardano-keys extraction PRs and adapt to them - #1444

Open
palas wants to merge 2 commits into
masterfrom
move-keys
Open

Pin the cardano-keys extraction PRs and adapt to them#1444
palas wants to merge 2 commits into
masterfrom
move-keys

Conversation

@palas

@palas palas commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

DO NOT MERGE: work in progress and contains SRPs

Context

In IntersectMBO/cardano-keys#4, we move cardano key machinery to a separate repo with fewer dependencies than cardano-api, so that they can be used by testing projects in the consensus repos, among others, without having to depend in the full stack that cardano-api requires.

This PR pins cardano-keys IntersectMBO/cardano-keys#4 and IntersectMBO/cardano-api#1332 with SRPs to ensure the integration will work once releases start.

How to trust this PR

Really small changes and just test that CI works. But make sure there are no SRPs or master exceptions before merging.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff
  • Changelog fragment added in .changes/

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

It intentionally introduces temporary SRP pins and a CI master-check exception mechanism that need an explicit removal/merge plan (or updated merge intent) before it’s suitable to merge.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR temporarily pins unreleased cardano-keys and an adopting cardano-api via source-repository-package stanzas to validate the in-flight key-extraction integration, and adapts cardano-cli to the resulting API changes.

Changes:

  • Add temporary source-repository-package pins for IntersectMBO/cardano-keys and IntersectMBO/cardano-api, plus a solver constraint for crypton.
  • Update golden tests to use textEnvelopeType as a free function instead of the HasTextEnvelope class method.
  • Adapt KES period handling to account for getKesPeriod returning KESPeriod (using unKESPeriod).
File summaries
File Description
cardano-cli/test/cardano-cli-golden/Test/Golden/Shelley/TextEnvelope/Keys/VRFKeys.hs Switch golden test to use textEnvelopeType free function.
cardano-cli/test/cardano-cli-golden/Test/Golden/Shelley/TextEnvelope/Keys/StakeKeys.hs Switch golden test to use textEnvelopeType free function.
cardano-cli/test/cardano-cli-golden/Test/Golden/Shelley/TextEnvelope/Keys/PaymentKeys.hs Switch golden test to use textEnvelopeType free function.
cardano-cli/test/cardano-cli-golden/Test/Golden/Shelley/TextEnvelope/Keys/KESKeys.hs Switch golden test to use textEnvelopeType free function.
cardano-cli/test/cardano-cli-golden/Test/Golden/Shelley/TextEnvelope/Keys/GenesisUTxOKeys.hs Switch golden test to use textEnvelopeType free function.
cardano-cli/test/cardano-cli-golden/Test/Golden/Shelley/TextEnvelope/Keys/GenesisKeys.hs Switch golden test to use textEnvelopeType free function.
cardano-cli/test/cardano-cli-golden/Test/Golden/Shelley/TextEnvelope/Keys/GenesisDelegateKeys.hs Switch golden test to use textEnvelopeType free function (incl. op cert counter type).
cardano-cli/test/cardano-cli-golden/Test/Golden/Shelley/TextEnvelope/Keys/ExtendedPaymentKeys.hs Switch golden test to use textEnvelopeType free function.
cardano-cli/test/cardano-cli-golden/Test/Golden/Shelley/TextEnvelope/Certificates/Operational.hs Switch operational certificate golden test to use textEnvelopeType free function.
cardano-cli/src/Cardano/CLI/EraBased/Query/Run.hs Convert KESPeriod via unKESPeriod when computing op cert starting KES period.
cabal.project Add temporary SRP pins and a crypton < 1.1 solver constraint.
.github/master-check-exceptions.list Add exceptions for the pinned git dependencies to bypass the “on master/release branch” check temporarily.
.changes/pin-cardano-keys-extraction.yml Changelog entry describing the temporary pinning and API adaptations.
Review details
  • Files reviewed: 13/13 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/master-check-exceptions.list
Comment thread cabal.project
@palas
palas requested a review from a team as a code owner September 10, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants