Conversation
palas
requested review from
Jimbo4350,
carbolymer,
disassembler,
kevinhammond and
newhoggy
as code owners
September 10, 2026 14:24
This was referenced Sep 10, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
It intentionally introduces temporary SRP pins and a CI master-check exception mechanism that need an explicit removal/merge plan (or updated merge intent) before it’s suitable to merge.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR temporarily pins unreleased cardano-keys and an adopting cardano-api via source-repository-package stanzas to validate the in-flight key-extraction integration, and adapts cardano-cli to the resulting API changes.
Changes:
- Add temporary
source-repository-packagepins forIntersectMBO/cardano-keysandIntersectMBO/cardano-api, plus a solver constraint forcrypton. - Update golden tests to use
textEnvelopeTypeas a free function instead of theHasTextEnvelopeclass method. - Adapt KES period handling to account for
getKesPeriodreturningKESPeriod(usingunKESPeriod).
File summaries
| File | Description |
|---|---|
| cardano-cli/test/cardano-cli-golden/Test/Golden/Shelley/TextEnvelope/Keys/VRFKeys.hs | Switch golden test to use textEnvelopeType free function. |
| cardano-cli/test/cardano-cli-golden/Test/Golden/Shelley/TextEnvelope/Keys/StakeKeys.hs | Switch golden test to use textEnvelopeType free function. |
| cardano-cli/test/cardano-cli-golden/Test/Golden/Shelley/TextEnvelope/Keys/PaymentKeys.hs | Switch golden test to use textEnvelopeType free function. |
| cardano-cli/test/cardano-cli-golden/Test/Golden/Shelley/TextEnvelope/Keys/KESKeys.hs | Switch golden test to use textEnvelopeType free function. |
| cardano-cli/test/cardano-cli-golden/Test/Golden/Shelley/TextEnvelope/Keys/GenesisUTxOKeys.hs | Switch golden test to use textEnvelopeType free function. |
| cardano-cli/test/cardano-cli-golden/Test/Golden/Shelley/TextEnvelope/Keys/GenesisKeys.hs | Switch golden test to use textEnvelopeType free function. |
| cardano-cli/test/cardano-cli-golden/Test/Golden/Shelley/TextEnvelope/Keys/GenesisDelegateKeys.hs | Switch golden test to use textEnvelopeType free function (incl. op cert counter type). |
| cardano-cli/test/cardano-cli-golden/Test/Golden/Shelley/TextEnvelope/Keys/ExtendedPaymentKeys.hs | Switch golden test to use textEnvelopeType free function. |
| cardano-cli/test/cardano-cli-golden/Test/Golden/Shelley/TextEnvelope/Certificates/Operational.hs | Switch operational certificate golden test to use textEnvelopeType free function. |
| cardano-cli/src/Cardano/CLI/EraBased/Query/Run.hs | Convert KESPeriod via unKESPeriod when computing op cert starting KES period. |
| cabal.project | Add temporary SRP pins and a crypton < 1.1 solver constraint. |
| .github/master-check-exceptions.list | Add exceptions for the pinned git dependencies to bypass the “on master/release branch” check temporarily. |
| .changes/pin-cardano-keys-extraction.yml | Changelog entry describing the temporary pinning and API adaptations. |
Review details
- Files reviewed: 13/13 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE: work in progress and contains SRPs
Context
In IntersectMBO/cardano-keys#4, we move cardano key machinery to a separate repo with fewer dependencies than
cardano-api, so that they can be used by testing projects in the consensus repos, among others, without having to depend in the full stack thatcardano-apirequires.This PR pins
cardano-keysIntersectMBO/cardano-keys#4 and IntersectMBO/cardano-api#1332 with SRPs to ensure the integration will work once releases start.How to trust this PR
Really small changes and just test that CI works. But make sure there are no SRPs or master exceptions before merging.
Checklist
.changes/