fix(ssrf): protect metadata-validation from SSRF attacks - #4212
Open
hummern wants to merge 1 commit into
Open
Conversation
…idation - Add validateUrl() function with protocol whitelist (http, https, ipfs) - Block private/internal IP ranges (10/8, 172.16/12, 192.168/16, 169.254/16, 127/8, 0/8) - Block localhost and cloud metadata endpoints - Add helper functions isPrivateIP() and isBlockedHostname() - Apply validation before fetch in app.service.ts - Returns URL_NOT_FOUND status for blocked URLs instead of throwing - Fixes IntersectMBO#4142 - SSRF in Metadata-Validation Service via Loopback Escalation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #4142 - SSRF in Metadata-Validation Service
Vulnerability
The metadata-validation service's method fetched URLs without any validation, allowing attackers to:
Fix
Added comprehensive URL validation with:
Files Changed
Testing
Security Impact