feat: enforce the circuit verification key registry - #3514
Draft
jpraynaud wants to merge 6 commits into
Draft
Conversation
Test Results 5 files ± 0 221 suites ±0 1h 0m 32s ⏱️ - 41m 46s Results for commit 222ca3e. ± Comparison against base commit cccb650. This pull request removes 58 and adds 13 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
9 tasks
Base automatically changed from
jpraynaud/3148-introduce-circuit-key-registry
to
main
September 9, 2026 16:10
jpraynaud
force-pushed
the
jpraynaud/3148-enforce-circuit-key-registry
branch
from
September 10, 2026 09:55
f85a019 to
286b261
Compare
Check the circuit verification key digests against the registry certifier before verifying SNARK certificates, on both the standard and the full chain shortcut paths, failing closed when the certifier is missing.
Resolve the registry of the client's network through the published networks configuration, with a CLI parameter reading it from a local file for tests.
…ation Wire the certifier into the certificate verifier and the chain synchronizer when a signed registry file path is configured, so SNARK certificates fail fast at creation when their circuit keys are not certified.
Export the circuit key digests, whitelist or revoke a key with a genesis signed registry update, sign a registry and bootstrap one for tests.
Generate the signed registry on the fly with the devnet genesis key at genesis bootstrap, in the system temporary directory read by default by the aggregators and pointed at by the clients.
Cover the registry format, offline signing, publication at the repository root, rotation and the revocation procedure.
jpraynaud
force-pushed
the
jpraynaud/3148-enforce-circuit-key-registry
branch
from
September 10, 2026 11:09
286b261 to
222ca3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content
This PR includes the enforcement and integration of the circuit verification key registry introduced in #3513:
MithrilCertificateVerifierfor theSnarkandIvcSnarkaggregate signature types, on both the standard and the full chain shortcut pathsmithril-clientthrough the publishednetworks.json(aggregator endpoint match, genesis verification key fallback), enabled by default with bounded, retried and size-capped downloadscircuit_verification_key_registry_path(defaults to the data stores directory)genesis sign-circuit-key-registry(air-gapped signing with authoring validation) and test-onlygenesis bootstrap-circuit-key-registrysubcommands to the aggregatorPre-submit checklist
Issue(s)
Relates to #3148