Skip to content

fix: fail closed on unparsed review output - #713

Merged
unohee merged 2 commits into
mainfrom
heewonoh/agt-3099-release-0-24-1
Sep 20, 2026
Merged

unohee merged 2 commits into
mainfrom
heewonoh/agt-3099-release-0-24-1

Conversation

@unohee

@unohee unohee commented Sep 20, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • normalize a prefixed OpenSwarm JSON review document before reading action outputs
  • fail fail-on-gate-not-run whenever no parsed gateRan: true verdict exists, including exit code 0

Evidence

  • External cgf-portal E2E run 35479878890 exposed a real false-green: a late memory diagnostic prefixed the JSON document, the action emitted no changes, and the job passed despite gate-ran=false.
  • Reproduced the exact prefixed JSON shape locally; the new extractor recovered approve and gateRan=true.
  • git diff --check.

@unohee

unohee commented Sep 20, 2026

Copy link
Copy Markdown
Collaborator Author

🔍 Fresh review of 2911fe7 (openswarm pr review --fresh)

✓ Decision: APPROVE
Verified action.yml JSON parsing robustness (diagnostic noise, gate-not-run detection, clean-file extraction), intentional LanceDB downgrade for cross-platform npm ci, and CHANGELOG consistency. No defects found in the current diff.
Suggestions:
- Consider adding a similar parse-validation guard for the SARIF output path if the CLI can also embed diagnostics in SARIF stdout.

@unohee
unohee merged commit fe14edc into main Sep 20, 2026
8 checks passed
@unohee
unohee deleted the heewonoh/agt-3099-release-0-24-1 branch September 20, 2026 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant