Allow PointsList/PointsSidebar to open the settings of other PointsLists/Sidebars#174
Draft
menvae wants to merge 11 commits intoInventiveRhythm:mainfrom
Draft
Allow PointsList/PointsSidebar to open the settings of other PointsLists/Sidebars#174menvae wants to merge 11 commits intoInventiveRhythm:mainfrom
menvae wants to merge 11 commits intoInventiveRhythm:mainfrom
Conversation
Contributor
Author
|
Also I should mention that public void ShowPointInCharting(ITimedObject obj)
{
ChangeTab(1);
ChartingPoints.ShowPoint(obj);
}
public void ShowPointInDesign(ITimedObject obj)
{
ChangeTab(2);
DesignPoints.ShowPoint(obj);
} |
Contributor
Author
This is kinda outdated as of the latest commit. the change tab method is still here just in case, |
by "improving" what this actually means is just fully loading design tab so that we can safely reference its children
+ change tabs using variants instead of int
Contributor
Author
|
Drafting until further notice [1/12/2026] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clicking on scroll velocity and multiplier tags doesn't open the point in question.
This makes it so that points can be referenced from other pointslists.
Changes:
EditorTagDependenciesfor opening points from any points listCurrentTabinEditorpublic (only get) and a bindableOld Description
Clicking on scroll velocity and multiplier tags opens the sidebar in charting tab not their actual housing sidebar.
One caveat and I don't have a fix for it, is that design tab has to be loaded otherwise when switching to design tab and trying to show the entry nothing happens because it hasn't loaded yet. Other than that if design is already loaded (eg. just enter it one time) it will work fine.
Changes:
EditorTagDependenciesfor opening points in any points listCurrentTabinEditorpublic (only get) and a bindable