Skip to content

CI: Pin Foundry to v1.3.6 and repair KPI e2e test - #784

Merged
marvinkruse merged 3 commits into
devfrom
ci/pin-foundry
Oct 22, 2026
Merged

marvinkruse merged 3 commits into
devfrom
ci/pin-foundry

Conversation

@marvinkruse

Copy link
Copy Markdown
Member

Summary

CI currently fails on every PR (e.g. #781, #783) before any test runs. The workflow installs Foundry stable, and releases after the last green dev run (Oct 2025) break this repo:

  • Build: the post-build lint step added in newer Foundry crashes resolving an import inside lib/deterministic-factory (file src/interfaces/IDeterministicFactory_v1.sol not found, "internal lint engine failure (compilation itself succeeded)"). compile fails, and the other jobs fail because the compiled-artifacts artifact is missing.
  • Formatting: newer forge fmt reformats imports across the whole codebase, so verify-formatting would fail on untouched files too.

Separately, test_e2e_LM_PC_KPIRewarder_v2Lifecycle was broken:

  • It minted Sepolia USDC by impersonating a minter that can no longer mint (FiatToken: caller is not a minter).
  • It passed address(0x1) as the asserter, but since the Hats audit fixes ([Audit] Merging Hats Fixes into Dev #607) the bond is pulled from the asserter, so posting the assertion reverted with InsufficientFundsToPayForBond.

Changes

  • .github/workflows/ci.yml: pin foundry-toolchain to v1.3.6 in all jobs, the newest release that builds without the lint crash and passes the existing format check unchanged.
  • test/e2e/logicModule/KPIRewarderLifecycle.t.sol: fund the test contract with deal instead of minting, use the automation service as asserter, and approve the bond from it (unlimited, since every round posts a bond).

Deployment Steps

✅ No deployment steps required. CI and test only.

Test Plan

Pre-merge checklist

  • With Foundry v1.3.6 locally: forge build, make check-size, forge fmt --check, make testScripts all pass
  • forge test: 1570 passed, 0 failed (previously 1 failed: the KPI e2e test)
  • CI green on this PR

@marvinkruse
marvinkruse merged commit e480e8d into dev Oct 22, 2026
5 checks passed
@marvinkruse
marvinkruse deleted the ci/pin-foundry branch October 22, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant