Repository navigation
CI: Pin Foundry to v1.3.6 and repair KPI e2e test - #784
Merged
Merged
Conversation
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI currently fails on every PR (e.g. #781, #783) before any test runs. The workflow installs Foundry
stable, and releases after the last greendevrun (Oct 2025) break this repo:lib/deterministic-factory(file src/interfaces/IDeterministicFactory_v1.sol not found, "internal lint engine failure (compilation itself succeeded)").compilefails, and the other jobs fail because thecompiled-artifactsartifact is missing.forge fmtreformats imports across the whole codebase, soverify-formattingwould fail on untouched files too.Separately,
test_e2e_LM_PC_KPIRewarder_v2Lifecyclewas broken:FiatToken: caller is not a minter).address(0x1)as the asserter, but since the Hats audit fixes ([Audit] Merging Hats Fixes into Dev #607) the bond is pulled from the asserter, so posting the assertion reverted withInsufficientFundsToPayForBond.Changes
.github/workflows/ci.yml: pinfoundry-toolchaintov1.3.6in all jobs, the newest release that builds without the lint crash and passes the existing format check unchanged.test/e2e/logicModule/KPIRewarderLifecycle.t.sol: fund the test contract withdealinstead of minting, use the automation service as asserter, and approve the bond from it (unlimited, since every round posts a bond).Deployment Steps
✅ No deployment steps required. CI and test only.
Test Plan
Pre-merge checklist
forge build,make check-size,forge fmt --check,make testScriptsall passforge test: 1570 passed, 0 failed (previously 1 failed: the KPI e2e test)