[SDK-82] New Architecture#704

Merged

lposen merged 100 commits intomasterfrom

new-arch/master

Nov 3, 2025

Contributor

lposen commented Sep 30, 2025 •

edited

Loading

🔹 JIRA Ticket(s) if any

SDK-82

✏️ Description

This contains the following approved PRs:

This resolves the following client issues:

lposen and others added 30 commits

August 1, 2025 14:05


          feat: added the api, and fixed the tyes

efb6101


          refactor: updated codegen config to properly

0588f0d


          refactor: enhance ReactIterableAPI so that the functions are accessib…

13aaf54

…le from RNIterableAPI.mm


          refactor: integrate Swift-based ReactIterableAPI into RNIterableAPI f…

2c25245

…or new architecture


          feat: add Swift formatting configuration and formatted swift files

4145f1e


          chore: add .clang-format configuration and update Swift/cpp files for…

144b5ea

… consistent formatting


          Merge branch 'new-arch/MOB-11833-format-files' into new-arch/MOB-1182…

5debd41

…7-add-new-architecture-support


          fix: update Podfile to use dynamic linking for Iterable-iOS-SDK in RN…

47a7485

…IterableAPI module


          feat: configure code to support new and legacy architecture

7ff28f2


          refactor: update RNIterableAPI.mm to improve code clarity and remove …

8126d28

…unnecessary logging


          refactor: remove legacy architecture code to reduce PR bloat

5f8fd9f


          refactor: adjust RNIterableAPI to expose methods for both new and leg…

1b93af4

…acy architectures


          refactor: remove unused methods and logging from ReactIterableAPI.swi…

077a3a6

…ft to streamline code


          Merge branch 'new-arch/MOB-11827-add-new-architecture-support' into n…

a4800ea

…ew-arch/MOB-11828-add-backwards-compatibility


          feat: add test environment check to NativeRNIterableAPI export to fix…

fd99e15

… broken tests


          Merge branch 'new-arch/MOB-11826-make-frontend-api-and-codegen' into …

bc476b9

…new-arch/MOB-11833-format-files


          Merge branch 'new-arch/MOB-11833-format-files' into new-arch/MOB-1182…

e65d66c

…7-add-new-architecture-support


          Merge branch 'new-arch/MOB-11827-add-new-architecture-support' into n…

9e1fcdf

…ew-arch/MOB-11828-add-backwards-compatibility


          feat: add iOS module configuration for RNIterableAPI and ReactIterabl…

57dcf59

…eAPI in package.json


          Merge pull request #685 from Iterable/new-arch/MOB-11826-make-fronten…

1731f83

…d-api-and-codegen

[MOB-11826] make-frontend-api-and-codegen


          Merge pull request #686 from Iterable/new-arch/MOB-11833-format-files

a6245be

[MOB-11833] format-files


          Merge branch 'new-arch/master' into new-arch/MOB-11827-add-new-archit…

f7be0fa

…ecture-support


          Merge branch 'new-arch/MOB-11827-add-new-architecture-support' into n…

61b759d

…ew-arch/MOB-11828-add-backwards-compatibility


          refactor: update podspec for Iterable-React-Native-SDK to support Swi…

9a1e16d

…ft and iOS SDK dependency


          Merge branch 'new-arch/MOB-11827-add-new-architecture-support' into n…

288c158

…ew-arch/MOB-11828-add-backwards-compatibility


          Merge pull request #688 from Iterable/new-arch/MOB-11828-add-backward…

75dccb3

…s-compatibility

[MOB-11828] add-backwards-compatibility


          Update ios/RNIterableAPI/ReactIterableAPI.swift

29ba514

Added copilot suggestion

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>


          refactor: update ios/RNIterableAPI/ReactIterableAPI.swift with copilo…

6dbead4

…t suggestion

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>


          refactor: update ios/RNIterableAPI/ReactIterableAPI.swift with copilo…

c3e1389

…t suggestion

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>


          Merge pull request #687 from Iterable/new-arch/MOB-11827-add-new-arch…

de47698

…itecture-support

[MOB-11827] add-new-architecture-support


          Merge branch 'master' into new-arch/master

410e84a

qltysh bot reviewed

View reviewed changes

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java Show resolved Hide resolved

src/core/classes/Iterable.ts Show resolved Hide resolved

lposen marked this pull request as ready for review

October 9, 2025 10:30

lposen and others added 2 commits

October 9, 2025 05:09


          refactor: temporary fix for circular paths, which break expo

9c09743


          Merge pull request #734 from Iterable/new-arch/circ-depend

c11cf70

refactor: temporary fix for circular paths, which break expo

qltysh bot reviewed

View reviewed changes

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java Show resolved Hide resolved

src/core/classes/Iterable.ts Show resolved Hide resolved


          chore: update version to 2.1.0-beta.1 in package.json and itblBuildIn…

d531104

…fo.ts

qltysh bot reviewed

View reviewed changes

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java Show resolved Hide resolved

src/core/classes/Iterable.ts Show resolved Hide resolved


          chore: downgrade version to 2.1.0-beta.0 in package.json

83a20df

qltysh bot reviewed

View reviewed changes

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java Show resolved Hide resolved

src/core/classes/Iterable.ts Show resolved Hide resolved


          chore: update CHANGELOG.md for version 2.1.0-beta.1 with temporary fi…

7cee550

…x for circular paths

qltysh bot reviewed

View reviewed changes

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java Show resolved Hide resolved

src/core/classes/Iterable.ts Show resolved Hide resolved


          chore: bump version to 2.1.0-beta.1 in package.json

b730eb5

qltysh bot reviewed

View reviewed changes

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java Show resolved Hide resolved

src/core/classes/Iterable.ts Show resolved Hide resolved


          Merge branch 'master' into new-arch/master

fef5b69

qltysh bot reviewed

View reviewed changes

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java Show resolved Hide resolved

src/core/classes/Iterable.ts Show resolved Hide resolved

lposen changed the title ~~New arch/master~~ [SDK-82] New Architecture


          Merge branch 'master' into new-arch/master

607a55b

qltysh bot reviewed

View reviewed changes

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java Show resolved Hide resolved

src/core/classes/Iterable.ts Show resolved Hide resolved

lposen added the rn new arch label


          Merge branch 'master' into new-arch/master

99db035

qltysh bot reviewed

View reviewed changes

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java Show resolved Hide resolved

src/core/classes/Iterable.ts Show resolved Hide resolved


          Merge branch 'master' into new-arch/master

169c584

qltysh bot reviewed

View reviewed changes

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java Show resolved Hide resolved

src/core/classes/Iterable.ts Show resolved Hide resolved

evantk91 approved these changes

View reviewed changes

Ayyanchira approved these changes

View reviewed changes

Member

Ayyanchira left a comment

Skimmed over all the files. Not deeply reviewed


          fix: remove node only call

ca88683

qltysh bot reviewed

View reviewed changes

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java

+                      // MOB-10421: Figure out what the error cases are and handle them appropriately
+                      // This is just here to match the TS types and let the JS thread know when we are done initializing
+                      promise.resolve(true);

qltysh bot Nov 3, 2025

Found 2 issues:

1. Function with high complexity (count = 5): initializeWithApiKey [qlty:function-complexity]

2. Function with many parameters (count = 4): initializeWithApiKey [qlty:function-parameters]

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java

-                  @ReactMethod
-                  public void trackPushOpenWithCampaignId(Integer campaignId, Integer templateId, String messageId, Boolean appAlreadyRunning, ReadableMap dataFields) {
-                      RNIterableInternal.trackPushOpenWithCampaignId(campaignId, templateId, messageId, optSerializedDataFields(dataFields));
+                  public void trackPushOpenWithCampaignId(double campaignId, @Nullable Double templateId, String messageId, boolean appAlreadyRunning, @Nullable ReadableMap dataFields) {

qltysh bot Nov 3, 2025

Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java

-                  @ReactMethod
-                  public void updateSubscriptions(ReadableArray emailListIds, ReadableArray unsubscribedChannelIds, ReadableArray unsubscribedMessageTypeIds, ReadableArray subscribedMessageTypeIds, Integer campaignId, Integer templateId) {
+                  public void updateSubscriptions(@Nullable ReadableArray emailListIds, @Nullable ReadableArray unsubscribedChannelIds, @Nullable ReadableArray unsubscribedMessageTypeIds, @Nullable ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {

qltysh bot Nov 3, 2025

Function with many parameters (count = 6): updateSubscriptions [qlty:function-parameters]

src/core/classes/Iterable.ts

+                  unsubscribedMessageTypeIds: number[] | null,
+                  subscribedMessageTypeIds: number[] | null,
                   campaignId: number,
                   templateId: number

qltysh bot Nov 3, 2025

Function with many parameters (count = 6): updateSubscriptions [qlty:function-parameters]

lposen merged commit 91937fe into master

12 of 14 checks passed

lposen deleted the new-arch/master branch

November 3, 2025 20:11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels