Skip to content

[SDK-151] cannot-read-property-authtoken-of-undefined#779

Merged
lposen merged 3 commits intojwt/masterfrom
feature/SDK-151-cannot-read-property-authtoken-of-undefined
Nov 10, 2025
Merged

[SDK-151] cannot-read-property-authtoken-of-undefined#779
lposen merged 3 commits intojwt/masterfrom
feature/SDK-151-cannot-read-property-authtoken-of-undefined

Conversation

@lposen
Copy link
Contributor

@lposen lposen commented Nov 10, 2025 •
edited by atlassian bot
Loading

🔹 JIRA Ticket(s) if any

✏️ Description

Please provide a brief description of what this pull request does.

@qltysh
Copy link

qltysh bot commented Nov 10, 2025 •
edited
Loading

3 new issues

Tool Category Rule Count
qlty Structure Deeply nested control flow (level = 4) 2
qlty Structure Function with high complexity (count = 5): isIterableAuthResponse 1

This is from Qlty Cloud, the successor to Code Climate Quality. Learn more.

qltysh[bot]
qltysh bot reviewed Nov 10, 2025
View reviewed changes
@lposen lposen added the jwt label Nov 10, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 10, 2025
View reviewed changes
src/core/classes/IterableLogger.ts
static log(message?: unknown, ...optionalParams: unknown[]) {
if (!IterableLogger.loggingEnabled) return;

console.log(message, ...optionalParams);

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information High

This logs sensitive data returned by
an access to apiKey
Loading
as clear text.
This logs sensitive data returned by
an access to apiKey
Loading
as clear text.
@github-actions
Copy link

github-actions bot commented Nov 10, 2025 •
edited
Loading

Lines Statements Branches Functions
Coverage: 57%
 57.91% (322/556) 33.03% (75/227) 56.15% (114/203)

@qltysh
Copy link

qltysh bot commented Nov 10, 2025 •
edited
Loading

Diff Coverage: The code coverage on the diff in this pull request is 100.0%.

Total Coverage: This PR will increase coverage by 0.58%.

File Coverage Changes
Path File Coverage Δ Indirect
src/core/classes/Iterable.ts 1.4
🛟 Help

  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

This is from Qlty Cloud, the successor to Code Climate Quality. Learn more.

qltysh[bot]
qltysh bot reviewed Nov 10, 2025
View reviewed changes
@lposen lposen changed the base branch from master to jwt/master November 10, 2025 22:32
qltysh[bot]
qltysh bot reviewed Nov 10, 2025
View reviewed changes
qltysh[bot]
qltysh bot reviewed Nov 10, 2025
View reviewed changes
src/core/classes/Iterable.ts
) {
return true;
}
return false;
Copy link

@qltysh qltysh bot Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with high complexity (count = 5): isIterableAuthResponse [qlty:function-complexity]

src/core/classes/Iterable.ts
if ((promiseResult as IterableAuthResponse).successCallback) {
(promiseResult as IterableAuthResponse).successCallback?.();
if (promiseResult.successCallback) {
promiseResult.successCallback?.();
Copy link

@qltysh qltysh bot Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deeply nested control flow (level = 4) [qlty:nested-control-flow]

src/core/classes/Iterable.ts
if ((promiseResult as IterableAuthResponse).failureCallback) {
(promiseResult as IterableAuthResponse).failureCallback?.();
if (promiseResult.failureCallback) {
promiseResult.failureCallback?.();
Copy link

@qltysh qltysh bot Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deeply nested control flow (level = 4) [qlty:nested-control-flow]

Ayyanchira
Ayyanchira reviewed Nov 10, 2025
View reviewed changes
src/core/classes/Iterable.ts
Iterable.authManager.passAlongAuthToken(promiseResult as string);
Iterable.authManager.passAlongAuthToken(promiseResult);
} else {
IterableLogger?.log(
Copy link
Member

@Ayyanchira Ayyanchira Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can also consider calling failure callback here with appropriate message.

Copy link
Contributor Author

@lposen lposen Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeahhh I agree.. just don't want to mix concerns in the PR

Ayyanchira
Ayyanchira approved these changes Nov 10, 2025
View reviewed changes
Copy link
Member

@Ayyanchira Ayyanchira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Made a nit pick comment which could be outside scope of this bug fix

@lposen lposen merged commit c6548d2 into jwt/master Nov 10, 2025
13 of 14 checks passed
@lposen lposen deleted the feature/SDK-151-cannot-read-property-authtoken-of-undefined branch November 10, 2025 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qltysh qltysh[bot] qltysh[bot] left review comments

@Ayyanchira Ayyanchira Ayyanchira approved these changes

Assignees

No one assigned

Labels

jwt

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lposen @Ayyanchira