fix: resolve OpenSSL version against available vcpkg versions#447
Open
fix: resolve OpenSSL version against available vcpkg versions#447
Conversation
When the exact OpenSSL version from Node.js isn't available in vcpkg, the build fails. This adds version resolution that finds the closest compatible version: preferring a newer patch on the same minor line, then falling back to the closest lower patch, then the next minor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/vcpkg-openssl-version.jswith version parsing, comparison, and resolution logic for OpenSSL versions in the vcpkg registryscripts/vcpkg-setup.jsto resolve the Node.js OpenSSL version against what's actually available in vcpkg, instead of assuming an exact match existsTest plan