Skip to content

txt files with var min max dimensions - #23

Open
cmgas wants to merge 16 commits into
developfrom
feature/add_txt_descriptors
Open

txt files with var min max dimensions#23
cmgas wants to merge 16 commits into
developfrom
feature/add_txt_descriptors

Conversation

@cmgas

@cmgas cmgas commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Description

Happy to not merge this, but I was thinking that maybe it would be useful to be able to see what the nc files contain? Then when people issue a PR they can modify the txt too and it's a little easier to understand for reviewers.

@cmgas cmgas self-assigned this Jul 17, 2026
@cmgas
cmgas requested review from mikecooke77 and svahl991 July 17, 2026 17:33
Base automatically changed from feature/rh_01 to develop August 4, 2026 15:35
@svahl991

svahl991 commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

@fmahebert I was curious if you had thoughts on this idea. I do like the additional visibility this adds. But it does create a little additional work.

@svahl991
svahl991 requested a review from fmahebert August 17, 2026 19:41
@fmahebert

Copy link
Copy Markdown
Collaborator

I also like the visibility, but I'm reluctant to put in data redundancy like this because I think we'll rapidly find these files falling out of sync.

But I'd be ok with merging a python script that produces this output, because that could be useful for exploring the repo, and also for asking contributors to include its output into their PRs.

What do you think of that variation on your idea @cmgas @svahl991 ?

@svahl991

Copy link
Copy Markdown
Collaborator

for asking contributors to include its output into their PRs.

So, for my understanding, are you suggesting that in a PR that updates a data file, the creator would use the new script to provide a diff of the script's output before and after the change from the PR, but the output file itself would not go into the repo?

@fmahebert

Copy link
Copy Markdown
Collaborator

are you suggesting that in a PR that updates a data file, the creator would use the new script to provide a diff of the script's output before and after the change from the PR, but the output file itself would not go into the repo?

I hadn't thought through to completion. What you propose (run script on develop branch + feature branch, diff output, paste output) is more useful than where I had stopped (run script on feature branch, paste output), but feels like a lot of work to be asking of contributors. Can we discuss next time we're all in office?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants