release: prepare Agent Switch 0.3.0 - #12
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 17fe1fe72c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "X_API_SECRET=sk-secret000000000004", | ||
| "X_ACCESS_TOKEN=sk-secret000000000005", | ||
| "X_ACCESS_TOKEN_SECRET=sk-secret000000000006", | ||
| "TAVILY_API_KEY=fixture-tavily-secret", |
There was a problem hiding this comment.
Check the replacement fixture values for leakage
After these fixtures stop using the sk-secret prefix, the assertion at the end of this test still checks only self.assertNotIn("sk-secret", combined). Consequently, leaking any of the new credential values into a reconciled client configuration or the doctor report would no longer fail this integration test. Check every replacement value (or retain a shared sentinel) so the test continues guarding against secret disclosure.
Useful? React with 👍 / 👎.
Summary
Verification