Minor changes to the ML scripts#15
Merged
Merged
Conversation
AbhirupaGhosh
changed the title
jananiravi
reviewed
Apr 3, 2026
jananiravi
left a comment
jananiravi
left a comment
Member
There was a problem hiding this comment.
Again, looks good to me, but need local runners: @epbrenner @eboyer221. Thanks!
AbhirupaGhosh
commented
May 8, 2026
Added Matthews correlation coefficient (MCC) and normalized MCC (nMCC) support throughout the package. Updated argument checks and plotting docs to accept an avg_mcc option, track mcc in runIFE results, and add related globals. Also updated README, vignette, and docs (including example file paths) to mention MCC and nMCC and to reflect the updated outputs. Moved Cje to Sfl (one consistent example throughout. Minor fixes: ensure test predictions are assigned to all_results in runMLPipeline and improve function return documentation.
jananiravi
previously approved these changes
May 11, 2026
jananiravi
left a comment
jananiravi
left a comment
Member
There was a problem hiding this comment.
added support for MCC + nMCC + minor fixes.
epbrenner
reviewed
Jun 10, 2026
epbrenner
reviewed
Jun 10, 2026
Updating user-facing language when class balance is assessed Co-authored-by: Evan Pierce Brenner <108823789+epbrenner@users.noreply.github.com>
Adding line 102 to prep_ml.R Co-authored-by: Abhirupa Ghosh <100681585+AbhirupaGhosh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some necessary updates
Description
What kind of change(s) are included?
Checklist
Please ensure that all boxes are checked before indicating that this pull request is ready for review.