fix(ui): page skipped-PR audit feed by offset instead of growing limit

[RealDiligent]

Summary

• Add a real offset query parameter to /v1/app/skipped-pr-audit (and MCP loopover_get_skipped_pr_audit) so pages are sliced server-side instead of growing limit.
• Change AuditFeed "Load more" to request the next offset page and append rows, so already-visible events never drop or reorder when newer skips land.
• Filter apply/reset (and reason changes) reload from offset=0 and replace the list.

Closes #7438

Scope

• The PR title follows type(scope): short summary Conventional Commit format, for example fix(api): restore profile access checks.
• This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
• This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
• I linked a currently open issue this PR resolves (e.g. Closes #123) — a linked open issue is required for every contributor PR.

Validation

• git diff --check
• npm run actionlint
• npm run typecheck
• npm run test:coverage locally; codecov/patch requires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.
• npm run test:workers
• npm run build:mcp
• npm run test:mcp-pack
• npm run ui:openapi (regenerated apps/loopover-ui/public/openapi.json)
• npm run ui:lint
• npm run ui:typecheck
• npm run ui:build
• npm audit --audit-level=moderate
• New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries

If any required check was skipped, explain why:

• Local: vitest for skipped-pr-audit, mcp-skipped-pr-audit, integration skipped-PR audit case, and audit-feed.test.tsx (all green). Remaining checks deferred to CI.

Safety

• No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
• Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
• Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests.
• API/OpenAPI/MCP behavior is updated and tested where needed.
• UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
• Visible UI changes include a UI Evidence section below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.
• Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

UI Evidence

Behavior-only pagination fix on the auth-gated AuditFeed ("Load more" appends via offset). No at-rest public visual delta — before/after are the same production dark-mode captures at each required viewport. loopover-ui is dark-mode-only.

Viewport · Theme	Before	After
Desktop · Dark
Tablet · Dark
Mobile · Dark

Notes

• Mirrors the dead-letter queue's offset request shape; AuditFeed keeps append UX (not Prev/Next page replace).

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.40%. Comparing base (fa67da4) to head (7087215).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7506      +/-   ##
==========================================
- Coverage   91.41%   91.40%   -0.02%     
==========================================
  Files         717      717              
  Lines       73038    73041       +3     
  Branches    21635    21639       +4     
==========================================
- Hits        66768    66760       -8     
- Misses       5227     5234       +7     
- Partials     1043     1047       +4     

Flag	Coverage Δ
shard-1	35.25% <0.00%> (-0.02%)	⬇️
shard-2	41.91% <0.00%> (-0.01%)	⬇️
shard-3	35.07% <87.50%> (-0.09%)	⬇️
shard-4	40.60% <50.00%> (-0.04%)	⬇️
shard-5	30.94% <0.00%> (-0.01%)	⬇️
shard-6	30.73% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/api/routes.ts	95.03% <100.00%> (+<0.01%)	⬆️
src/db/repositories.ts	96.72% <100.00%> (+<0.01%)	⬆️
src/mcp/server.ts	96.39% <100.00%> (ø)
src/openapi/schemas.ts	100.00% <ø> (ø)
src/openapi/spec.ts	99.47% <ø> (ø)

... and 2 files with indirect coverage changes

[loopover-orb]

Caution

🛑 LoopOver review result - reject/close recommended

_{Review updated: 2026-07-20 14:23:33 UTC}

12 files · 1 AI reviewer · 1 blocker · CI green · clean

🛑 Suggested Action - Reject/Close

Review summary
This correctly converts the skipped-PR audit feed from a growing-limit approach to real server-side offset pagination end-to-end: schema/openapi, the repository query (over-fetch sizing + slice + hasMore), the API route, the MCP tool, and the UI's append-on-load-more logic, all backed by new offset-paging tests (repository, API integration, MCP, UI). The core pagination math in listPrVisibilitySkipAuditEvents (offset+limit+1 over-fetch, slice(offset, offset+limit), hasMore = items.length > offset+limit) is correct and well covered by test/unit/skipped-pr-audit.test.ts's five-row paging case. The one real gap is a stale-closure race in AuditFeed.loadMore: it captures `data`, `repoFullName`, `reason`, and `sinceIso` from the render at click time, so if a user applies a filter while a load-more request is still in flight, the in-flight response resolves and overwrites the freshly filtered list with `[...staleData.items, ...newPageForOldFilter]`.

Blockers

• apps/loopover-ui/src/components/site/audit-feed.tsx:107-140 (loadMore): if the user clicks 'Load more' and then changes/applies a filter before the in-flight request resolves, loadMore's closure still holds the pre-filter `data`/`repoFullName`/`reason`/`sinceIso`, so its response is appended on top of the already-replaced, correctly-filtered `data` — silently reverting the UI to a mix of stale rows and an old-filter page; guard with a request-generation counter or abort/ignore the loadMore response if `filterPath` changed since the request was issued.

Nits — 5 non-blocking

• src/db/repositories.ts:3231 — the `2500`, `5`, and `20` constants in the over-fetch sizing formula are unexplained magic numbers (the prior `500` had the same issue); a named constant with the comment already present would make the sizing rationale easier to tune later.
• apps/loopover-ui/src/components/site/audit-feed.tsx: `loadMore` duplicates most of `load`'s fetch/normalize/error-handling logic inline rather than sharing a helper — acceptable for now but worth a follow-up if a third caller appears.
• The 'Load more' button has no `aria-busy`/disabled-visual distinction beyond the label text swap to 'Loading…', which is fine functionally but minor for a11y polish.
• Track an in-flight-request token (e.g. increment a ref on every load()/loadMore() call and compare on resolution) to make loadMore's stale-response race impossible instead of merely unlikely.
• Consider disabling the filter Apply/Reset controls (or cancelling the in-flight loadMore) while `loadingMore` is true, since that's a cheaper fix than a full request-token scheme.

Why this is blocked

• apps/loopover-ui/src/components/site/audit-feed.tsx:107-140 (loadMore): if the user clicks 'Load more' and then changes/applies a filter before the in-flight request resolves, loadMore's closure still holds the pre-filter `data`/`repoFullName`/`reason`/`sinceIso`, so its response is appended on top of the already-replaced, correctly-filtered `data` — silently reverting the UI to a mix of stale rows and an old-filter page; guard with a request-generation counter or abort/ignore the loadMore response if `filterPath` changed since the request was issued.

📋 Copy for AI agents — paste into your coding agent

Fix the following blocker(s) from this PR review:

1. apps/loopover-ui/src/components/site/audit-feed.tsx:107-140 \(loadMore\): if the user clicks 'Load more' and then changes/applies a filter before the in-flight request resolves, loadMore's closure still holds the pre-filter \`data\`/\`repoFullName\`/\`reason\`/\`sinceIso\`, so its response is appended on top of the already-replaced, correctly-filtered \`data\` — silently reverting the UI to a mix of stale rows and an old-filter page; guard with a request-generation counter or abort/ignore the loadMore response if \`filterPath\` changed since the request was issued.

Decision drivers

• ❌ Code review — 1 blocker (1 reviewer)
• ❌ Gate result — Blocking (Repo-configured hard blocker found.)

Context & advisory signals — never blocks the verdict

Signal	Result	Evidence
Linked issue	✅ Linked	#7438
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (1 linked issue).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 370 registered-repo PR(s), 171 merged, 34 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	RealDiligent; Gittensor profile; 370 PR(s), 34 issue(s).
Improvement	✅ Minor	risk: clean · value: minor · LLM: moderate

Linked issue satisfaction

Addressed
The PR adds a real offset parameter through buildSkippedPrAuditPath, the API route, MCP tool, and repository query (with hasMore computed from offset+limit vs. actual results), and changes loadMore to fetch the next offset page and append rows to existing state rather than replacing them; applyFilters/resetFilters reset to offset 0 via the filterPath reload. This directly follows the dead-letter-q

Review context

• Author: RealDiligent
• Role context: outside_contributor
• Public audience mode: oss maintainer
• Lane context: Repository is configured for direct PR review.
• Public profile languages: not available
• Official Gittensor activity: 370 PR(s), 34 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Keep the PR focused and include validation evidence before maintainer review.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

• @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
• @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
• A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

Visual preview

Route	Viewport	Before (production)	After (this PR's preview)	Diff
/	desktop	before /	after /	—
/	mobile	before / (mobile)	after / (mobile)	—

Click any thumbnail to open the full-size screenshot. Before = production · After = this PR's preview deploy.

Scroll preview

Route	Before (production)	After (this PR's preview)
/	before / (scroll)	—

A short scroll-through clip (desktop) — click either thumbnail to open the full animation. Evidence for scroll-linked behavior a single screenshot can't show.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

• Re-run LoopOver review

[loopover-orb]

LoopOver is closing this pull request on the maintainer's behalf (AI reviewers agree on a likely critical defect: apps/loopover-ui/src/components/site/audit-feed.tsx:107-140 (loadMore): if the user clicks 'Load more' and then changes/applies a filter before the in-flight request resolves, loadMore's closure still holds the pre-filter `data`/`repoFullName`/`reason`/`sinceIso`, so its response is appended on top of the already-replaced, correctly-filtered `data` — silently reverting the UI to a mix of stale rows and an old-filter page; guard with a request-generation counter or abort/ignore the loadMore response if `filterPath` changed since the request was issued.). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed.