feat(github): add milestone creation/assignment to the issue-planning tool#7511
Merged
Merged
Conversation
… tool Adds src/github/milestones.ts (listOpenInstallationMilestones, createInstallationMilestone) via the same installation-token/Orb- broker path as issue creation (#7425). Extends loopover_plan_repo_issues (#7426) with an optional milestone target: resolve-or-create by exact normalized-title match against existing open milestones (never fuzzy, to avoid silently grouping issues under the wrong one), then assign it to every created issue. Milestone title/description/dueOn are the caller's own input, never model-generated. Resolution degrades gracefully on failure (issues still get created, just ungrouped) rather than aborting the batch. Closes #7427
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7511 +/- ##
==========================================
- Coverage 91.43% 91.42% -0.02%
==========================================
Files 718 719 +1
Lines 73214 73253 +39
Branches 21692 21701 +9
==========================================
+ Hits 66944 66972 +28
- Misses 5227 5234 +7
- Partials 1043 1047 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
5 tasks
This was referenced Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/github/milestones.ts(listOpenInstallationMilestones,createInstallationMilestone) — GitHub-native milestones didn't exist as a capability anywhere in this codebase before this PR; every priormilestonereference was either the read-onlymilestoned/demilestonedwebhook event or an unrelated Linear-integration field. Both new functions go through the same installation-token/Orb-broker path as issue creation (#7425) — never a flat PAT.loopover_plan_repo_issues(#7426) with an optionalmilestonetarget (title/description/dueOn, all maintainer-supplied — never model-generated, per this sub-issue's own boundary). When creating ({create:true, dryRun:false}), the milestone is resolved once for the whole batch, then assigned to every issue actually created.normalizeIssueTitleKey, already generic) against existing open milestones — deliberately not fuzzy. A fuzzy match risks silently grouping issues under the wrong milestone, which is worse than creating a new, differently-named one. This mirrors the manual convention.claude/skills/contributor-pipeline-gardeningalready follows (reusing one milestone across recurring rounds) instead of spawning a fresh one every planning run under the same title.milestoneNumberabsent in the result), rather than the whole batch failing over a milestone-specific glitch.{create:true, dryRun:false}" contract.Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Closes #123) — a linked open issue is required for every contributor PR.Validation
git diff --checknpm run typechecknpm run test:coveragelocally — full unsharded suite: 1021 files / 19386 tests passed, 2 skipped. The same 9 pre-existing failures in 3 unrelated miner test files (tracked separately, unrelated to this PR) reproduce identically regardless of this change. New/changed code (src/github/milestones.ts, the milestone additions tosrc/services/issue-plan-draft.ts, the MCP wiring) is 100% branch-covered.npm run build:mcp/npm run test:mcp-packnpm run selfhost:env-reference:check/npm run ui:openapi:check/npm run docs:drift-check/npm run manifest:drift-check— all clean; no new env vars, no OpenAPI/manifest surface touched (MCP-only).npm run ui:lint/npm run ui:typecheck/npm run ui:build/npm run test:workers— not run; this PR touches no files underapps/loopover-ui/**or Cloudflare-workers-pool-specific code.test/unit/github-milestones.test.ts(7 tests, 100% branch coverage), milestone-specific additions totest/unit/issue-plan-draft.test.ts(6 new tests: no-op on dry run, create-new, reuse-by-normalized-title, empty-normalized-title, degrade-on-failure, no-installation) andtest/unit/mcp-plan-repo-issues.test.ts(milestone round-trip).If any required check was skipped, explain why:
ui:lint/ui:typecheck/ui:build/test:workers: noapps/loopover-ui/**or workers-pool-specific files changed.Safety
UI Evidencesection. (N/A — backend/MCP-only change.)UI Evidence
N/A — this is a backend/MCP-only change with no visible UI, frontend, or docs surface.
Notes
loopover_plan_repo_issuestool (already merged, #7476), built on #7425's installation-token/Orb-broker write path (already merged, #7467).Closes #7427