Skip to content

docs(client): JmHtmlClient#getAlbumDownloadInfo 目前无法实现 - #15

Merged
JUKOMU merged 1 commit into
masterfrom
dev
Jul 24, 2026
Merged

docs(client): JmHtmlClient#getAlbumDownloadInfo 目前无法实现#15
JUKOMU merged 1 commit into
masterfrom
dev

Conversation

@JUKOMU

@JUKOMU JUKOMU commented Jul 24, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • 文档
    • 补充 HTML 端获取本子下载信息的流程说明。
    • 说明验证码获取方式及需手动输入验证码的限制。
    • 未改变现有功能或用户操作方式。

@JUKOMU JUKOMU added the documentation Improvements or additions to documentation label Jul 24, 2026
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

getAlbumDownloadInfo 方法新增 Javadoc,说明 HTML 端获取下载地址的请求流程,以及验证码获取和人工输入限制。未修改方法实现或对外行为。

Changes

HTML 下载信息文档

Layer / File(s) Summary
补充下载流程说明
jmcomic-core/src/main/java/io/github/jukomu/jmcomic/core/client/impl/JmHtmlClient.java
getAlbumDownloadInfo 增加方法级 Javadoc,描述页面获取、参数提交、重定向下载地址获取及验证码处理限制。

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 标题准确概括了本次对 JmHtmlClient#getAlbumDownloadInfo 的文档说明更新,且与变更内容一致。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@jmcomic-core/src/main/java/io/github/jukomu/jmcomic/core/client/impl/JmHtmlClient.java`:
- Around line 439-450: 更新 JmHtmlClient 中下载信息方法的 Javadoc:明确说明该方法当前不支持,调用者应使用
JmApiClient,并将 GET → POST → 重定向 → GET 内容改为参考或待实现流程;同时保持现有
UnsupportedOperationException 行为不变。
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 068b4f48-7214-473d-b7f0-93a4fcc3c518

📥 Commits

Reviewing files that changed from the base of the PR and between 64dd056 and dc2b999.

📒 Files selected for processing (1)
  • jmcomic-core/src/main/java/io/github/jukomu/jmcomic/core/client/impl/JmHtmlClient.java

@JUKOMU
JUKOMU merged commit 550d82d into master Jul 24, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant