Skip to content

修复解析错误 - #7

Merged
JUKOMU merged 3 commits into
masterfrom
dev
Jul 11, 2026
Merged

修复解析错误#7
JUKOMU merged 3 commits into
masterfrom
dev

Conversation

@JUKOMU

@JUKOMU JUKOMU commented Jul 11, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Bug Fixes
    • 增强图片列表解析兼容性:当图片列表项为字符串时可直接读取文件名;不符合预期的内容将给出解析错误提示。
  • 文档
    • 更新 README、安装指南及集成/快速开始示例中的版本号至 1.1.7
  • 维护
    • 全项目及各模块版本升级至 1.1.7,相关构建与示例同步调整。

@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 824418a3-1f53-45eb-857c-f934e876fa65

📥 Commits

Reviewing files that changed from the base of the PR and between ed3d2e3 and e2ebdd3.

📒 Files selected for processing (1)
  • jmcomic-core/src/main/java/io/github/jukomu/jmcomic/core/parser/ApiParser.java
🚧 Files skipped from review as they are similar to previous changes (1)
  • jmcomic-core/src/main/java/io/github/jukomu/jmcomic/core/parser/ApiParser.java

📝 Walkthrough

Walkthrough

项目版本由 1.1.6 统一更新为 1.1.7,相关构建配置和文档示例同步调整;同时增强 buildImageList 对字符串及对象格式图片元素的解析兼容性。

Changes

版本号更新

Layer / File(s) Summary
构建版本链更新
pom.xml, jmcomic-*/pom.xml
根项目及各 Maven 模块的父项目版本更新为 1.1.7
文档依赖示例更新
README*.md, docs/sources/**
版本徽标及 Maven、Gradle 依赖示例中的版本号更新为 1.1.7

图片列表解析兼容性

Layer / File(s) Summary
图片元素格式兼容
jmcomic-core/src/main/java/io/github/jukomu/jmcomic/core/parser/ApiParser.java
图片元素支持直接读取字符串,或从对象的非空 image 字段读取;不支持的元素格式会抛出 ParseResponseException

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 标题准确概括了本次修复解析错误的核心代码变更。
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@jmcomic-core/src/main/java/io/github/jukomu/jmcomic/core/parser/ApiParser.java`:
- Around line 448-453: Update the filename extraction in ApiParser’s image-item
parsing block to branch explicitly on the JsonElement type instead of using
getAsString() exceptions for control flow: read string elements directly and
read the "image" property from object elements. Validate the object and property
before accessing them so malformed entries produce a clear, intentional error
rather than a swallowed NullPointerException.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 412b7f9e-7396-4665-8704-e410c44f4c1c

📥 Commits

Reviewing files that changed from the base of the PR and between 84db8b5 and ed3d2e3.

📒 Files selected for processing (12)
  • README.md
  • README_en.md
  • docs/sources/advanced/modular-integration.md
  • docs/sources/android.md
  • docs/sources/index.md
  • docs/sources/quickstart/installation.md
  • jmcomic-android-support/pom.xml
  • jmcomic-api/pom.xml
  • jmcomic-core/pom.xml
  • jmcomic-core/src/main/java/io/github/jukomu/jmcomic/core/parser/ApiParser.java
  • jmcomic-sample/pom.xml
  • pom.xml

@JUKOMU
JUKOMU merged commit 9760a96 into master Jul 11, 2026
2 checks passed
@JUKOMU JUKOMU added the bugfix Fixes a confirmed bug or defect in existing functionality. label Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Fixes a confirmed bug or defect in existing functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant