refactor: implement dynamic backup namespaces #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling mocker.patch("git_pulsar.cli.GitRepo") directly ensures the class
is mocked (preventing the ValueError from the real class) without creating
an unused variable that flags the linter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the core backup logic to use a pure git reference namespace (
refs/heads/wip/pulsar/...) instead of relying on a local "zombie" branch. This eliminates the need for the daemon to create or switch branches in the user's working directory, ensuringgit statusremains clean and preventing "detached HEAD" states during backup operations.Changes
constants.py): ReplacedBACKUP_BRANCHwithBACKUP_NAMESPACEto reflect that we are writing to a ref hierarchy, not a check-out-able branch.ops.py): Updatedget_backup_refand synchronization logic (finalize_work,sync_session) to construct references dynamically based on the current machine ID and active branch.cli.py): - Removedsetup_repologic that forced the creation/checkout ofwip/pulsar.status,diff, andlistcommands to resolve backup refs dynamically via a helper, fixing DRY violations.daemon.py): Updated the shadow commit logic to write directly to the namespaced ref without interacting with the working tree's HEAD.BACKUP_NAMESPACEconstant.Fixes
git-pulsar difforstatuswould crash or show incorrect info if the localwip/pulsarbranch was deleted.main.Verification
uv run pytestpasses (Tests updated to match new ref logic).git-pulsar statuscorrectly identifies backup state.finalizeandsynccommands successfully resolve remote references using the new namespace wildcard.