fix(nlab-api): broaden enum provenance analysis - #113
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Response fields populated through
name(), helper methods, constructors, builders, or object copies could lose their enum association. Known defaults such as99could also disappear from the generated enum, incorrectly narrowing its value set.Trace typed assignments and finite value propagation, share enum projections across response, request, and reverse lookup analysis, and retain extra literal members in field-specific enum variants. Preserve container shapes and report missing source or dynamic transformations without inventing values. CodeGraph itself is unchanged.
Validation:
cargo fmt --check,cargo clippy --locked --all-targets --all-features -- -D warnings, and all 399 repository tests passed. Ten coverage groups also passed with fresh real CodeGraph indexes; the original 18 probes verify actual generated enum members, with negative cases for unsafe narrowing and unrelated types.