Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s Rhiza template dependency to v0.13.3 and syncs template-managed files accordingly, including a shift from committed GitHub Actions workflow files under .github/workflows/ to template-provided workflow stubs under .rhiza/stubs/workflows/.
Changes:
- Bump
.rhiza/template.yml/.rhiza/template.lockto Rhiza templatev0.13.3and update the pinned template SHA. - Remove committed GitHub Actions workflows (and a composite action) from
.github/…and add stub workflow definitions under.rhiza/stubs/workflows/. - Update Rhiza’s internal test suite to accommodate template bundle validation changes and reduced workflow-structure assertions.
Reviewed changes
Copilot reviewed 22 out of 23 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
.rhiza/tests/structure/test_template_bundles.py |
Enhances template-bundles validation (path resolution, dependency-cycle and ownership checks). |
.rhiza/tests/api/test_weekly_workflow.py |
Removes detailed job assertions for weekly workflow (but still contains structure tests). |
.rhiza/tests/api/test_release_workflow.py |
Removes expected-jobs/update-changelog job validation, leaving only trigger/permission checks. |
.rhiza/tests/api/test_ci_workflow.py |
Drops YAML parsing workflow-structure tests; keeps Makefile-based OS-matrix tests. |
.rhiza/template.yml |
Bumps template ref to v0.13.3. |
.rhiza/template.lock |
Updates template SHA/ref and switches managed workflow assets to .rhiza/stubs/workflows/*. |
.rhiza/stubs/workflows/rhiza_weekly.yml |
Adds stub reusable-workflow caller for weekly checks. |
.rhiza/stubs/workflows/rhiza_sync.yml |
Adds stub reusable-workflow caller for template sync. |
.rhiza/stubs/workflows/rhiza_release.yml |
Adds stub reusable-workflow caller for release automation. |
.rhiza/stubs/workflows/rhiza_marimo.yml |
Adds stub reusable-workflow caller for marimo notebooks. |
.rhiza/stubs/workflows/rhiza_codeql.yml |
Adds stub reusable-workflow caller for CodeQL scanning. |
.rhiza/stubs/workflows/rhiza_ci.yml |
Adds stub reusable-workflow caller for CI. |
.rhiza/stubs/workflows/rhiza_book.yml |
Adds stub reusable-workflow caller for book build/deploy. |
.rhiza/.rhiza-version |
Bumps Rhiza tool version from 0.14.1 to 0.15.0. |
.github/workflows/rhiza_weekly.yml |
Deletes previously committed weekly workflow. |
.github/workflows/rhiza_sync.yml |
Deletes previously committed sync workflow. |
.github/workflows/rhiza_release.yml |
Deletes previously committed release workflow. |
.github/workflows/rhiza_marimo.yml |
Deletes previously committed marimo workflow. |
.github/workflows/rhiza_codeql.yml |
Deletes previously committed CodeQL workflow. |
.github/workflows/rhiza_ci.yml |
Deletes previously committed CI workflow. |
.github/workflows/rhiza_book.yml |
Deletes previously committed book workflow. |
.github/actions/configure-git-auth/README.md |
Deletes documentation for the removed composite action. |
.github/actions/configure-git-auth/action.yml |
Deletes the composite action previously used by workflows. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
106
to
108
|
|
||
| # --- jobs present --- | ||
|
|
Comment on lines
106
to
108
|
|
||
| # --- jobs present --- | ||
|
|
Comment on lines
66
to
69
| def test_workflow_has_contents_write_permission(self, workflow): | ||
| """Workflow must have contents: write permission to push CHANGELOG.md.""" | ||
| permissions = workflow.get("permissions", {}) | ||
| assert permissions.get("contents") == "write", "Workflow must have contents: write permission" |
Comment on lines
59
to
69
| def test_workflow_triggers_on_version_tags(self, workflow): | ||
| """Workflow must trigger on version tags (v*).""" | ||
| triggers = workflow.get("on") or workflow.get(True) or {} | ||
| push = triggers.get("push", {}) | ||
| tags = push.get("tags", []) | ||
| assert any("v*" in tag for tag in tags), "Workflow must trigger on v* tags" | ||
|
|
||
| def test_workflow_defines_all_expected_jobs(self, workflow): | ||
| """Workflow must define all expected jobs including update-changelog.""" | ||
| defined_jobs = set(workflow["jobs"].keys()) | ||
| for job in EXPECTED_JOBS: | ||
| assert job in defined_jobs, f"Job '{job}' not found in workflow" | ||
|
|
||
| def test_workflow_has_contents_write_permission(self, workflow): | ||
| """Workflow must have contents: write permission to push CHANGELOG.md.""" | ||
| permissions = workflow.get("permissions", {}) | ||
| assert permissions.get("contents") == "write", "Workflow must have contents: write permission" |
Comment on lines
41
to
+50
| - .rhiza/requirements/tools.txt | ||
| - .rhiza/rhiza.mk | ||
| - .rhiza/semgrep.yml | ||
| - .rhiza/stubs/workflows/rhiza_book.yml | ||
| - .rhiza/stubs/workflows/rhiza_ci.yml | ||
| - .rhiza/stubs/workflows/rhiza_codeql.yml | ||
| - .rhiza/stubs/workflows/rhiza_marimo.yml | ||
| - .rhiza/stubs/workflows/rhiza_release.yml | ||
| - .rhiza/stubs/workflows/rhiza_sync.yml | ||
| - .rhiza/stubs/workflows/rhiza_weekly.yml |
|
|
||
| jobs: | ||
| ci: | ||
| uses: jebel-quant/rhiza/.github/workflows/rhiza_ci.yml@v0.11.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make syncGenerated with Claude Code