Repository navigation
ci: smoke-test Grafana and Prometheus, not just the collector (#78) - #85
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #78.
The "It comes up" step now publishes
9090and3000as well as9109. A new step after it, "Prometheus scrapes it and Grafana serves the board", waits on:/-/ready/api/health/api/dashboards/uid/jq-fleet, which must return 200 with at least one panel (the board is provisioned, not just Grafana running)/api/datasources/uid/jq-prometheus/health, which must return"status":"OK", so Grafana can reach Prometheusup{job="jq-collector"}= 1, so Prometheus 3 still readsprometheus.ymland scrapes the collectorEvery wait gives up early, printing
docker logs, if the container exits.Verified locally, running this step's script from the workflow with only the ports remapped:
/etc/grafana/dashboardstimed out waiting for …/api/dashboards/uid/jq-fleet(404), whiledocker psreported the containerhealthyThe second row is the case the issue describes. Grafana keeps running without the board, so neither the healthcheck nor the entrypoint's "any exit stops the container" rule catches it.
This run also answers the open question from #75: Grafana 13.2.3 and Prometheus 3.15.0 serve the board correctly, with no error lines from either in the logs.
Gates
prek run --all-files: all hooks pass, including actionlint (with shellcheck over the newrun:block).Closes #78
🤖 Generated with Claude Code