fix: stabilise MenuPortal updateComputedPosition to prevent infinite re-render loop#6097
Open
9KenM wants to merge 2 commits intoJedWatson:masterfrom
Open
fix: stabilise MenuPortal updateComputedPosition to prevent infinite re-render loop#60979KenM wants to merge 2 commits intoJedWatson:masterfrom
9KenM wants to merge 2 commits intoJedWatson:masterfrom
Conversation
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
updateComputedPositioncloses overcomputedPositionand lists itssub-properties (
offset,rect.left,rect.width) asuseCallbackdependencies. This means every call to
setComputedPositionproduces anew callback identity, which invalidates the
useLayoutEffect([updateComputedPosition])and immediately re-fires thecallback.
Under subpixel-drifting conditions (zoomed-out viewport, scrollable
ancestor, or fractional DPI) the measured
offsetoscillates by <1pxbetween frames. Each oscillation triggers
setComputedPosition→identity change → effect re-run → repeat, until React throws:
Fixes #6003.
Solution
Track
computedPositionin a ref so the comparison insideupdateComputedPositionalways reads the latest value without thecallback depending on it. This gives
updateComputedPositiona stableidentity across renders and breaks the loop.
Reproduction
<Select menuPosition="fixed" />inside a scrollable container