fix: Update MAF Doctor version to 1.18.0 and... - #125
Merged
Merged
Conversation
…ed agents - see maf-doctor-assessment.md
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
A duplicate DI registration causes the web app to ignore its configured output-token cap, and related documentation remains stale.
Review effort: Balanced
Findings: 1
Open (3)
What changed in this PR
Updates MAF Doctor integration and remediates credential and token-cap findings.
Changes:
- Uses system-assigned managed identities for hosted agents.
- Adds configurable per-response output-token limits.
- Updates MAF Doctor configuration, assessment, and tests.
| File | Description |
|---|---|
TokenCapChatClient.cs |
Adds output-token defaults and validation. |
Program.cs |
Reads the console output-token setting. |
HostedAgents/Reviewer/Program.cs |
Uses managed identity. |
HostedAgents/Researcher/Program.cs |
Uses managed identity. |
HostedAgents/Blogger/Program.cs |
Uses managed identity. |
HostedAgents/Author/Program.cs |
Uses managed identity. |
docs/maf-doctor-assessment.md |
Records findings and remediation. |
BlogWriterServiceCollectionExtensions.cs |
Configures the web token cap. |
BlogWriter.Tests/TokenCapChatClientTests.cs |
Tests output-cap behavior. |
BlogWriter.Tests/TestChatClients.cs |
Captures forwarded options in tests. |
.vscode/mcp.json |
Updates MAF Doctor to 1.18.0. |
.mcp.json |
Updates MAF Doctor to 1.18.0. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| out int configuredMaxOutputTokens) | ||
| ? configuredMaxOutputTokens | ||
| : TokenCapChatClient.DefaultMaxOutputTokens; | ||
| services.AddSingleton(TokenCapChatClient.CreateSharedFactory(maxTokens, maxOutputTokens)); |
|
|
||
| After the credential and output-cap changes on `fix/maf-doctor-findings`: | ||
|
|
||
| - All four hosted agents use an explicit system-assigned managed identity. Each hosted-agent project builds without warnings. |
| After the credential and output-cap changes on `fix/maf-doctor-findings`: | ||
|
|
||
| - All four hosted agents use an explicit system-assigned managed identity. Each hosted-agent project builds without warnings. | ||
| - The shared chat-client factory now supplies an 8192-token per-response default while preserving explicit per-call values. Override it with `MAX_OUTPUT_TOKENS` in the console app, or `Foundry:MaxOutputTokens` / `MAX_OUTPUT_TOKENS` in the web app. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
address findings in hosted agents - see maf-doctor-assessment.md