Skip to content

test: add CommitPulseLogo error resilience coverage#3643

Open
pari7maheshwari wants to merge 3 commits into
JhaSourav07:mainfrom
pari7maheshwari:test/commitpulse-logo-error-resilience
Open

test: add CommitPulseLogo error resilience coverage#3643
pari7maheshwari wants to merge 3 commits into
JhaSourav07:mainfrom
pari7maheshwari:test/commitpulse-logo-error-resilience

Conversation

@pari7maheshwari
Copy link
Copy Markdown
Contributor

Description

Fixes #2668

Added components/commitpulse-logo.error-resilience.test.tsx to cover hydration stability, exception safety, telemetry logging, and recovery fallback behavior for CommitPulseLogo.

Changes made

  • Added 5 error-resilience test cases.
  • Simulated runtime exceptions through a controlled test double.
  • Verified error boundaries prevent application crashes.
  • Verified fallback recovery UI is rendered on failure.
  • Verified telemetry/error handlers receive runtime exceptions.
  • Verified retry/reset recovery paths are available.
  • Verified healthy renders do not trigger fallback UI.
  • Added react-error-boundary dependency to support error-boundary testing.

Pillar

  • 🎨 Pillar 1 — New Theme Design
  • 📐 Pillar 2 — Geometric SVG Improvement
  • 🕐 Pillar 3 — Timezone Logic Optimization
  • 🛠️ Other (Bug fix, refactoring, docs)

Visual Preview

N/A (test-only changes)

Checklist before requesting a review:

  • I have read the CONTRIBUTING.md file.
  • I have tested these changes locally (localhost:3000/api/streak?user=YOUR_USERNAME).
  • I have run npm run format and npm run lint locally and resolved all errors.
  • My commits follow the Conventional Commits format.
  • I have updated README.md if I added a new theme or URL parameter.
  • I have started the repo.
  • I have made sure that I have only one commit to merge in this PR.
  • The SVG output matches the CommitPulse "premium quality" aesthetic standard (not applicable — test-only changes).
  • (Recommended) I joined the CommitPulse Discord community for contributor discussions, mentorship, and faster PR support.

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Jun 4, 2026

@pari7maheshwari is attempting to deploy a commit to the jhasourav07's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Copy Markdown
Collaborator

@Aamod007 Aamod007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there! 👋 Thanks for your contribution! I noticed two issues that need to be addressed before we can merge this:

  1. The test file uses a mocked CommitPulseLogo and defines FallbackRecoveryUI directly within the test file. This means the tests are verifying the
    eact-error-boundary library's behavior rather than our actual application code! To make these tests meaningful, please test the real component and its actual error boundary.
  2. The package-lock.json file is included in the PR. To avoid unexpected dependency updates and merge conflicts, please revert the changes to package-lock.json and let the CI handle dependency locking.

Let me know if you need any help making these changes!

@Aamod007 Aamod007 added gssoc26 GSSoC 2026 mentor:Aamod007 status:blocked This PR is blocked due to a failing CI check. testing labels Jun 4, 2026
Copy link
Copy Markdown
Collaborator

@Aamod007 Aamod007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the code side! However, the CI checks are failing. Please fix the CI issues so this can be merged.

@Aamod007 Aamod007 added level:intermediate Moderate complexity tasks quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. type:testing Adding, updating, or fixing tests and removed gssoc26 labels Jun 4, 2026
@pari7maheshwari
Copy link
Copy Markdown
Contributor Author

LGTM on the code side! However, the CI checks are failing. Please fix the CI issues so this can be merged.

Thanks for the review! I'll take a look at the failing CI checks, address the issues, and push an update shortly.

Copy link
Copy Markdown
Collaborator

@Aamod007 Aamod007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The error resilience coverage for CommitPulseLogo is excellent. CI is passing now, good to go!

@pari7maheshwari
Copy link
Copy Markdown
Contributor Author

LGTM! The error resilience coverage for CommitPulseLogo is excellent. CI is passing now, good to go!

Alright .

@github-actions github-actions Bot removed the status:blocked This PR is blocked due to a failing CI check. label Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GSSoC 2026 level:intermediate Moderate complexity tasks mentor:Aamod007 quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. testing type:testing Adding, updating, or fixing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(commitpulse-logo-error-resilience): verify Hydration Stability, Exception Safety & Error Fallbacks (Variation 6)

2 participants