test: add CommitPulseLogo error resilience coverage#3643
test: add CommitPulseLogo error resilience coverage#3643pari7maheshwari wants to merge 3 commits into
Conversation
|
@pari7maheshwari is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
Aamod007
left a comment
There was a problem hiding this comment.
Hi there! 👋 Thanks for your contribution! I noticed two issues that need to be addressed before we can merge this:
- The test file uses a mocked CommitPulseLogo and defines FallbackRecoveryUI directly within the test file. This means the tests are verifying the
eact-error-boundary library's behavior rather than our actual application code! To make these tests meaningful, please test the real component and its actual error boundary. - The package-lock.json file is included in the PR. To avoid unexpected dependency updates and merge conflicts, please revert the changes to package-lock.json and let the CI handle dependency locking.
Let me know if you need any help making these changes!
Aamod007
left a comment
There was a problem hiding this comment.
LGTM on the code side! However, the CI checks are failing. Please fix the CI issues so this can be merged.
Thanks for the review! I'll take a look at the failing CI checks, address the issues, and push an update shortly. |
Aamod007
left a comment
There was a problem hiding this comment.
LGTM! The error resilience coverage for CommitPulseLogo is excellent. CI is passing now, good to go!
Alright . |
Description
Fixes #2668
Added
components/commitpulse-logo.error-resilience.test.tsxto cover hydration stability, exception safety, telemetry logging, and recovery fallback behavior forCommitPulseLogo.Changes made
react-error-boundarydependency to support error-boundary testing.Pillar
Visual Preview
N/A (test-only changes)
Checklist before requesting a review:
CONTRIBUTING.mdfile.localhost:3000/api/streak?user=YOUR_USERNAME).npm run formatandnpm run lintlocally and resolved all errors.README.mdif I added a new theme or URL parameter.