fix: consolidate duplicate rate limiter implementations#3653
Conversation
|
@REHAN-503 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
👋 Hey @REHAN-503, it looks like you didn't use our PR template! The section Please update your PR description to include all required sections so we can review this properly:
You can find the full template in CONTRIBUTING.md. Just edit your PR description and the |
|
Please pull the latest changes and resolve the conflicts so we can review it! git fetch origin
git rebase origin/main
# resolve any conflicts, then:
git push --force-with-leaseOnce resolved, the |
b43c387 to
5edb179
Compare
- Remove duplicate rateLimit() implementation - Update middleware to use rateLimit() function - Fix tests to align with new implementation - Resolve merge conflicts with upstream/main Fixes JhaSourav07#1797
Aamod007
left a comment
There was a problem hiding this comment.
LGTM! Consolidating the rate limiter is a clean refactor.
|
👋 Hey @REHAN-503! Thanks for your contribution! 🎉 Unfortunately, this PR has been automatically closed because it is not linked to any open issue. To resolve this, please do the following:
We look forward to reviewing your PR once an issue is linked! 🚀 |
Description
Fixes #1797
This PR consolidates the application's rate-limiting implementation by removing the standalone middleware-specific rate limiter and reusing the existing RateLimiter class across the codebase.
What changed
Why
The repository contained two separate rate-limiting implementations:
Pillar
Checklist