Skip to content

fix(calculate): return 'N/A' instead of empty string for mostActiveDate on empty calendar#3655

Open
ChetanSenta wants to merge 1 commit into
JhaSourav07:mainfrom
ChetanSenta:fix/wrapped-stats-most-active-date-empty-string
Open

fix(calculate): return 'N/A' instead of empty string for mostActiveDate on empty calendar#3655
ChetanSenta wants to merge 1 commit into
JhaSourav07:mainfrom
ChetanSenta:fix/wrapped-stats-most-active-date-empty-string

Conversation

@ChetanSenta
Copy link
Copy Markdown
Contributor

Description

Fixes #3642

Pillar

  • 🎨 Pillar 1 — New Theme Design
  • 📐 Pillar 2 — Geometric SVG Improvement
  • 🕐 Pillar 3 — Timezone Logic Optimization
  • 🛠️ Other (Bug fix, refactoring, docs)

Visual Preview

No SVG visual change. This is a pure data correctness fix in lib/calculate.ts.
GithubWrapped.tsx will now render "N/A" instead of a blank field for users
with zero contributions.

Checklist before requesting a review:

  • I have read the CONTRIBUTING.md file.
  • I have tested these changes locally (localhost:3000/api/streak?user=YOUR_USERNAME).
  • I have run npm run format and npm run lint locally and resolved all errors (CI will fail otherwise).
  • My commits follow the Conventional Commits format (e.g., feat(themes): ..., fix(calculate): ...).
  • I have updated README.md if I added a new theme or URL parameter.
  • I have starred the repo.
  • I have made sure that i have only one commit to merge in this PR.
  • The SVG output matches the CommitPulse "premium quality" aesthetic standard (no raw elements, smooth animations, correct fonts).
  • (Recommended) I joined the CommitPulse Discord server for faster collaboration, mentorship, and PR support.

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Jun 4, 2026

Someone is attempting to deploy a commit to the jhasourav07's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Copy Markdown
Collaborator

@Aamod007 Aamod007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The fix for mostActiveDate empty string is correct.

@Aamod007 Aamod007 added level:beginner Small changes Usually isolated fixes or simple UI/text updates. GSSoC 2026 mentor:Aamod007 quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. type:bug Something isn't working as expected labels Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GSSoC 2026 level:beginner Small changes Usually isolated fixes or simple UI/text updates. mentor:Aamod007 quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. type:bug Something isn't working as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: calculateWrappedStats returns empty string for mostActiveDate when calendar has no contributions

2 participants