test(Heatmap-empty-fallback): verify Edge Cases & Empty/Missing Inputs Verification (Variation 1)#3657
Conversation
|
🚨 Hey @Thacker-Meet, the CI Pipeline is failing on this PR and it has been marked as Please fix the issues before this can be reviewed. Here's how: 1. Run checks locally before pushing: npm run format:check # Check Prettier formatting
npm run lint # Run ESLint
npm run typecheck # TypeScript type check
npm run test # Run unit tests (Vitest)
npm run build # Verify production build passes2. Auto-fix common issues: npm run format # Auto-fix formatting with Prettier
npm run lint -- --fix # Auto-fix lint errors where possible3. Check the full failure log here: Once you push a fix and the CI passes, the |
|
The CI failure appears unrelated to this PR. The failing test is: TestingLibraryElementError: My PR only adds: The new Heatmap tests pass locally and CI reports 3735 tests passed with only this unrelated repository test failing. Could you please check whether this is a pre-existing failure on the updated base branch? |
Aamod007
left a comment
There was a problem hiding this comment.
LGTM! Edge cases for empty Heatmap data are well handled.
Aamod007
left a comment
There was a problem hiding this comment.
LGTM on the code side! However, the CI checks are failing. Please fix the CI issues so this can be merged.
|
Hi @Aamod007 I checked the raw CI logs. The failing test is: TestingLibraryElementError: The workflow reports: My PR only adds: The Heatmap tests pass locally, and I couldn't find any failure related to the new test file. Could you please confirm whether the failing "popular-repos" test is unrelated to this PR or point me to the specific file that needs fixing? Thanks! |
Description
Fixes #2553
Added empty fallback test coverage for
Heatmap.Pillar
Visual Preview
Checklist before requesting a review:
CONTRIBUTING.mdfile.npm run formatandnpm run lintlocally and resolved all errors (CI will fail otherwise).feat(themes): ...,fix(calculate): ...).Changes Made
components/dashboard/Heatmap.empty-fallback.test.tsxResult