Skip to content

test(Heatmap-empty-fallback): verify Edge Cases & Empty/Missing Inputs Verification (Variation 1)#3657

Open
Thacker-Meet wants to merge 2 commits into
JhaSourav07:mainfrom
Thacker-Meet:test/heatmap-empty-fallback
Open

test(Heatmap-empty-fallback): verify Edge Cases & Empty/Missing Inputs Verification (Variation 1)#3657
Thacker-Meet wants to merge 2 commits into
JhaSourav07:mainfrom
Thacker-Meet:test/heatmap-empty-fallback

Conversation

@Thacker-Meet
Copy link
Copy Markdown
Contributor

Description

Fixes #2553

Added empty fallback test coverage for Heatmap.

Pillar

  • 🛠️ Other (Bug fix, refactoring, docs)

Visual Preview

  • N/A (test-only change)

Checklist before requesting a review:

  • I have read the CONTRIBUTING.md file.
  • I have run npm run format and npm run lint locally and resolved all errors (CI will fail otherwise).
  • My commits follow the Conventional Commits format (e.g., feat(themes): ..., fix(calculate): ...).
  • I have starred the repo.
  • I have made sure that I have only one commit to merge in this PR.

Changes Made

  • Created components/dashboard/Heatmap.empty-fallback.test.tsx
  • Added empty array fallback rendering coverage
  • Added custom fallback message validation
  • Added zero-contribution dataset fallback coverage
  • Verified heatmap grid is not rendered in empty state
  • Verified title and subtitle remain visible in fallback layouts

Result

  • Improves resilience coverage for Heatmap
  • Verifies empty and missing activity scenarios render safely
  • Helps prevent regressions in fallback UI behavior
  • Confirms fallback layouts preserve key page structure
  • All newly added tests pass successfully

@github-actions github-actions Bot added the status:blocked This PR is blocked due to a failing CI check. label Jun 4, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

🚨 Hey @Thacker-Meet, the CI Pipeline is failing on this PR and it has been marked as status:blocked.

Please fix the issues before this can be reviewed. Here's how:

1. Run checks locally before pushing:

npm run format:check   # Check Prettier formatting
npm run lint           # Run ESLint
npm run typecheck      # TypeScript type check
npm run test           # Run unit tests (Vitest)
npm run build          # Verify production build passes

2. Auto-fix common issues:

npm run format         # Auto-fix formatting with Prettier
npm run lint -- --fix  # Auto-fix lint errors where possible

3. Check the full failure log here:
👉 View CI Run

Once you push a fix and the CI passes, the status:blocked label will be removed automatically. 💪

@Thacker-Meet
Copy link
Copy Markdown
Contributor Author

Hi @Aamod007 @JhaSourav07

The CI failure appears unrelated to this PR.

The failing test is:

TestingLibraryElementError:
Unable to find an element by:
[data-testid="popular-repos"]

My PR only adds:
components/dashboard/Heatmap.empty-fallback.test.tsx

The new Heatmap tests pass locally and CI reports 3735 tests passed with only this unrelated repository test failing.

Could you please check whether this is a pre-existing failure on the updated base branch?

Copy link
Copy Markdown
Collaborator

@Aamod007 Aamod007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Edge cases for empty Heatmap data are well handled.

@Aamod007 Aamod007 added level:intermediate Moderate complexity tasks GSSoC 2026 mentor:Aamod007 quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. type:testing Adding, updating, or fixing tests labels Jun 4, 2026
Copy link
Copy Markdown
Collaborator

@Aamod007 Aamod007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the code side! However, the CI checks are failing. Please fix the CI issues so this can be merged.

@Thacker-Meet
Copy link
Copy Markdown
Contributor Author

Thacker-Meet commented Jun 4, 2026

Hi @Aamod007

I checked the raw CI logs.

The failing test is:

TestingLibraryElementError:
Unable to find an element by:
[data-testid="popular-repos"]

The workflow reports:
3735 passed, 1 failed, 1 expected fail.

My PR only adds:
components/dashboard/Heatmap.empty-fallback.test.tsx

The Heatmap tests pass locally, and I couldn't find any failure related to the new test file. Could you please confirm whether the failing "popular-repos" test is unrelated to this PR or point me to the specific file that needs fixing?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GSSoC 2026 level:intermediate Moderate complexity tasks mentor:Aamod007 quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. status:blocked This PR is blocked due to a failing CI check. type:testing Adding, updating, or fixing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(Heatmap-empty-fallback): verify Edge Cases & Empty/Missing Inputs Verification (Variation 1)

2 participants