Fixed missing import in sample as well as added index + "typo" fix#2
Open
AirplanegoBrr wants to merge 2 commits intoJiloc:mainfrom
Open
Fixed missing import in sample as well as added index + "typo" fix#2AirplanegoBrr wants to merge 2 commits intoJiloc:mainfrom
AirplanegoBrr wants to merge 2 commits intoJiloc:mainfrom
Conversation
Added import of `PropertyEvent` and also added index to GetPropertyData as well as a "typo" fix to the SetCapacity comment
Added index to `GetPropertyData` function
Author
|
This pull fixes #1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a missing import,
PropertyEventfor thecallback_propertyfunction (in the example)There is no index set for the
GetPropertyData(default doesn't work?)As well as a better description for the
SetCapacityfunction (in the example)The term "Computer" was used as people can have both HDDs and SSDs so computer was a better pick.