Two small changes allowing for vectorized .observe()#1
Open
xmichaelx wants to merge 5 commits intoJoshPaterson:vectorize-atfrom
Open
Two small changes allowing for vectorized .observe()#1xmichaelx wants to merge 5 commits intoJoshPaterson:vectorize-atfrom
xmichaelx wants to merge 5 commits intoJoshPaterson:vectorize-atfrom
Conversation
To also pass other tests with observe at
Author
|
Added some more ifs so it doesn't break basic logic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I've added to your fork some minor additions and observe now seems to work. Some more discussion is in your PR to official skyfield repo: skyfielders#532
Just want to help to get vectorized support into skyfield cause I'm gonna need it myself soonish in my projects :)