test: harmless edit to trigger the external benchmark gate#3
Open
Joshdb-Amazon wants to merge 3 commits into
Open
test: harmless edit to trigger the external benchmark gate#3Joshdb-Amazon wants to merge 3 commits into
Joshdb-Amazon wants to merge 3 commits into
Conversation
Adds .github/workflows/benchmark-external.yml so a maintainer can run the gate on an EXTERNAL (fork) PR. The default pull_request gate can't -- fork PRs get no secrets -- so this uses pull_request_target to access KIRO_API_KEY, guarded so it only runs when a maintainer opts a PR in. Control model: - Triggers ONLY on the "labeled" event; the job runs ONLY if the label is "run-benchmark". A fork contributor cannot self-add the label, so nothing runs until a maintainer reviews the PR and applies it. - A later push does NOT re-run it -- the maintainer must re-label (re-review). - permissions: contents: read (drops the default write GITHUB_TOKEN). The maintainer who labels a PR is taking responsibility for it: the job runs the PR's contributed skill while holding KIRO_API_KEY, so only label PRs you've reviewed. Use a service-account key so it can be rotated independently. On its own branch (not main) so it can be adopted separately from the internal gate.
Add label-triggered external-PR benchmark gate (security-sensitive; n…
Joshdb-Amazon
added
the
run-benchmark
Joshdb-Amazon
added
run-benchmark
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.