Add on_underflow option to enable ignoring or just warning about volume underflows#101
Merged
michaelosthege merged 5 commits intomasterfrom Jun 23, 2025
Merged
Add on_underflow option to enable ignoring or just warning about volume underflows#101michaelosthege merged 5 commits intomasterfrom
on_underflow option to enable ignoring or just warning about volume underflows#101michaelosthege merged 5 commits intomasterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #101 +/- ##
==========================================
+ Coverage 95.71% 95.75% +0.04%
==========================================
Files 19 19
Lines 1189 1202 +13
==========================================
+ Hits 1138 1151 +13
Misses 51 51 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This makes it easier to ignore underflows that are done on purpose, for example when aspirating supernatant.
e73520a to
54b4161
Compare
tobiaslatour
approved these changes
Jun 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VolumeViolationWarning,VolumeUnderflowWarningwere added.on_underflow: Literal["debug", "warn", "raise"]option was added toLabware.remove,BaseWorklist.aspirate,EvoWorklist.transferandFluentWorklist.transfer.VolumeUnderflowError.min_volume.BaseWorklist.