Skip to content

Jp/zernike partials#150

Open
ioannisPApapadopoulos wants to merge 8 commits intoJuliaApproximation:masterfrom
ioannisPApapadopoulos:jp/zernike-partials
Open

Jp/zernike partials#150
ioannisPApapadopoulos wants to merge 8 commits intoJuliaApproximation:masterfrom
ioannisPApapadopoulos:jp/zernike-partials

Conversation

@ioannisPApapadopoulos
Copy link
Copy Markdown
Member

I managed to implement the partial derivatives with respect to y. The following code now runs:

`using MultivariateOrthogonalPolynomials

W = Weighted(Zernike(1))
Δ = Laplacian(axes(W,1))

∂ʸ = PartialDerivative{2}(axes(W,1))

Z⁰ = Zernike(0)
Z¹ = Zernike(1)

∂Y² = (Z¹ \ (∂ʸ * Z⁰)) * (Z⁰ \ (∂ʸ * W))
Δ = Z¹ \ (Laplacian(axes(W,1)) * W)

z=2.0; A = (∂Y² - z*Δ);
c = A[Block.(1:50), Block.(1:50)] \ rand(1275)`

@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2023

Codecov Report

❌ Patch coverage is 95.23810% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.17%. Comparing base (02b1216) to head (b80a9a4).
⚠️ Report is 43 commits behind head on master.

Files with missing lines Patch % Lines
src/disk.jl 95.23% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
- Coverage   96.21%   96.17%   -0.05%     
==========================================
  Files           6        6              
  Lines         846      888      +42     
==========================================
+ Hits          814      854      +40     
- Misses         32       34       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/disk.jl Outdated
Comment thread src/disk.jl Outdated
Comment thread src/disk.jl Outdated
Comment thread src/disk.jl Outdated
Comment thread src/disk.jl Outdated
@ioannisPApapadopoulos
Copy link
Copy Markdown
Member Author

Windows tests are failing but that seems to be the case in the main branch as well. Not sure why the code coverage has decreased.. I'm covering the lines that it's complaining about in the tests.

@TSGut
Copy link
Copy Markdown
Member

TSGut commented May 29, 2023

I've noticed in other packages that the macro @simplify screws with coverage. I don't know why but as far as I've seen those lines never satisfy the coverage checks.

Comment thread src/disk.jl Outdated
Comment thread src/disk.jl Outdated
Comment thread src/disk.jl Outdated
Comment thread src/disk.jl Outdated
ioannisPApapadopoulos and others added 3 commits June 21, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants