Validate external_inputs/external_outputs names in connect (#114)#138
Merged
baggepinnen merged 2 commits intomasterfrom May 8, 2026
Merged
Validate external_inputs/external_outputs names in connect (#114)#138baggepinnen merged 2 commits intomasterfrom
baggepinnen merged 2 commits intomasterfrom
Conversation
Names not present in the assembled system used to silently prefix-match internal ports, producing the wrong external inputs. Error instead. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Single-prefix matches like `:x` -> `Symbol("x(t)")` are still accepted
(LQG tests rely on this). Only multi-result prefix expansion or no-match
at all errors now.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #138 +/- ##
==========================================
+ Coverage 90.89% 90.93% +0.04%
==========================================
Files 20 20
Lines 3031 3045 +14
==========================================
+ Hits 2755 2769 +14
Misses 276 276
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #114.
connectnow errors when anexternal_inputsorexternal_outputsname isn't present among the assembled system's inputs/outputs. Previously such names silently prefix-matched internal ports, producing the wrong externals.Test plan
test/test_named_systems2.jlpasses locally, including new@test_throwscases for both directions.🤖 Generated with Claude Code