Normalize string encodings before column edits - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StringVectorcopied arbitraryAbstractStringcode units as UTF-8. UTF-16/32 inputs failed even thoughDataString(input)worked, and Latin-1 inputs could silently produce incorrect text.Normalize other string implementations through
Stringat the shared append boundary.String,SubString{String},DataString, andSubString{DataString}keep their direct UTF-8 paths. This fixes construction and all column edits without a new dependency or API. Other string implementations may allocate a temporary converted String.Validation: 3,691 full-suite assertions on Julia 1.12 and 3,689 on Julia 1.10; five static-compilation/execution checks on Julia 1.13. New tests cover UTF-16/32, Latin-1, retained values, and zero-allocation UTF-8 edits with spare capacity. Original and fixed direct paths both allocate zero bytes in repeated warmed checks.
Co-authored by Codex