Skip to content

fixed bug with empty constructors#86

Open
kragol wants to merge 5 commits into
JuliaData:mainfrom
kragol:patch-1
Open

fixed bug with empty constructors#86
kragol wants to merge 5 commits into
JuliaData:mainfrom
kragol:patch-1

Conversation

@kragol
Copy link
Copy Markdown

@kragol kragol commented Jul 28, 2023

fixes #85

@bkamins
Copy link
Copy Markdown
Member

bkamins commented Jul 28, 2023

Thank you for reporting. Could you please add tests for the changed methods?

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 28, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.56%. Comparing base (1bb9c95) to head (fe23cfd).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #86      +/-   ##
==========================================
+ Coverage   87.97%   88.56%   +0.58%     
==========================================
  Files           1        1              
  Lines         341      341              
==========================================
+ Hits          300      302       +2     
+ Misses         41       39       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kragol
Copy link
Copy Markdown
Author

kragol commented Jul 28, 2023

Tests added.

Comment thread test/runtests.jl Outdated
@bkamins
Copy link
Copy Markdown
Member

bkamins commented Jul 28, 2023

I have added some more tests. Thank you for contributing.

Comment thread test/runtests.jl Outdated
Comment thread test/runtests.jl Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug with empty constructors

2 participants