Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StringArray stores UTF-8 bytes, but assignment copied arbitrary AbstractString storage through pointer. UTF-16/UTF-32 WeakRefString values raised a MethodError, and pointerless strings also failed.
Normalize other string representations through String before copying. Keep direct storage access for String, SubString{String}, and WeakRefString{UInt8}, and restrict the buffer-alias shortcut to UTF-8 views. Preserve the copied data during pointer access.
Refs #59.
Validation: all 199 tests passed on Julia 1.12.6. New tests fail before the fix and cover UTF-16, UTF-32, empty/non-ASCII values, multidimensional assignment, and LazyString. Warmed String, SubString, and UTF-8 WeakRefString assignments each allocate 0 bytes when the destination buffer has capacity.
Co-authored by Codex