Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Constructing StringArray from another StringArray returned the same mutable object or shared its storage. Changing the new array therefore changed the source.
Add a specialized constructor that copies the converted storage. Explicit convert calls retain their documented no-copy behavior. The copy preserves missing values and unassigned slots without reading them.
Refs #53.
Validation: the new tests failed on the original implementation; all 210 tests pass on Julia 1.12.6. Tests cover inferred and explicit element types, WeakRefString views, vector/matrix mutation isolation, missing/unassigned entries, and unchanged storage sharing through convert.
Co-authored by Codex