Mark adapt_structure and adapt_storage public#115
Merged
maleadt merged 1 commit intoJun 24, 2026
Conversation
These are the documented extension points downstream packages overload (per the `adapt` docstring and README: "implement methods of `adapt_structure` and `adapt_storage`"), but they were neither exported nor marked public, so tooling that checks public-API usage (e.g. ExplicitImports.jl, increasingly used in SciML/JuliaGPU test suites) flags every `Adapt.adapt_structure` override as a non-public access. Mark them public via `eval(Expr(:public, ...))` guarded on VERSION >= 1.11 so the file still parses on the 1.10 floor. No new dependency. version 4.6.1 -> 4.7.0. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
maleadt
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adapt_structureandadapt_storageare the documented extension points downstream packages overload (theadaptdocstring and the README both say to "implement methods ofadapt_structureandadapt_storage"), but they're neither exported nor markedpublic. Tooling that checks public-API usage (e.g. ExplicitImports.jl, increasingly run in SciML/JuliaGPU test suites) therefore flags everyAdapt.adapt_structureoverride as a non-public access, forcing per-repo ignore-lists across the ecosystem.This marks both names
publicviaeval(Expr(:public, ...))guarded onVERSION >= v"1.11"so the file still parses on Adapt's Julia 1.10 floor. No new dependency and no behavior change.Verified:
Base.ispublic(Adapt, :adapt_structure) == true(andadapt_storage) on 1.12; loads cleanly on the 1.10 LTS; full test suite passes; Runic-clean. version 4.6.1 → 4.7.0.