feat: implement IGraphAlg generic dispatch and C wrappers#45
feat: implement IGraphAlg generic dispatch and C wrappers#45mahmudsudo wants to merge 6 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #45 +/- ##
=========================================
- Coverage 5.28% 4.86% -0.43%
=========================================
Files 8 8
Lines 4311 4459 +148
=========================================
- Hits 228 217 -11
- Misses 4083 4242 +159 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
741034d to
6395d6b
Compare
Krastanov
left a comment
There was a problem hiding this comment.
Thanks for pushing on this @mahmudsudo ! We do not have many volunteer reviewers right now, so reminders on review are appreciated (and necessary, otherwise we just forget to do a review).
Could you help me a bit to understand how these things fit together, I see your PRs 43, 44, 45 and the Graphs.jl PR 506. Let's not worry about 506 for now. In 43 we discussed that the PR is rather large and dealing with multiple independent tasks so I asked to have it split so that it is easy to review it. Thank you for doing that, it does make things much easier for me to proceed with. However, the PR description above is empty, so I am not sure the overall goals you are pursuing -- could you enumerate the changes/reasons?
I also left a few minor comments in.
This PR completes the integration of the igraph C library into the Graphs.jl ecosystem.
Note: This PR is stacked on #43 and #44