Skip to content

Abstract l/rmul and l/rdiv types - #137

Open
jishnub wants to merge 5 commits into
masterfrom
abstractlrmuldiv
Open

Abstract l/rmul and l/rdiv types#137
jishnub wants to merge 5 commits into
masterfrom
abstractlrmuldiv

Conversation

@jishnub

@jishnub jishnub commented Jun 13, 2023

Copy link
Copy Markdown
Member

This defines abstract types for LMul/RMul/LDiv/RDiv, and defines some of the methods for the supertypes rather than the specific types.

@codecov

codecov Bot commented Jun 13, 2023

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.09%. Comparing base (14721f1) to head (9f96e09).
⚠️ Report is 101 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
+ Coverage   87.08%   87.09%   +0.01%     
==========================================
  Files          10       10              
  Lines        1773     1775       +2     
==========================================
+ Hits         1544     1546       +2     
  Misses        229      229              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jishnub
jishnub requested a review from dlfivefifty June 13, 2023 09:02
@dlfivefifty

Copy link
Copy Markdown
Member

What's the motivation for this?

@jishnub

jishnub commented Jun 14, 2023

Copy link
Copy Markdown
Member Author

To reduce the number of methods that need to be defined, which may improve the package-load and compile times slightly (although I haven't benchmarked these). From a design perspective, it seems redundant to define identical methods for every subtype.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants