Increase test coverage, fix NaN#93
Open
AshtonSBradley wants to merge 7 commits intoJuliaMath:masterfrom
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #93 +/- ##
==========================================
+ Coverage 84.89% 87.88% +2.98%
==========================================
Files 7 7
Lines 1470 1502 +32
==========================================
+ Hits 1248 1320 +72
+ Misses 222 182 -40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR increases test coverage to address #30. Coverage is up ~3% for the package and special cases are addressed more thoroughly. @dlfivefifty @MikaelSlevinsky I hope this helps package robustness.
This PR should also close #73 and #79. Both were caused by finite terminating hypergeometric series being routed through generic evaluation paths that could hit 0/0-style intermediate states and return NaN; this branch now detects those terminating cases and evaluates the finite sum directly.
It also adds regression coverage for the _₂F₁ special-case behaviour tied to #86 so should help resolve it.
Coverage-wise, this PR also helps address #30 by adding direct tests for internal helper functions, explicit _₂F₁ special-case branches, and issue-driven regression blocks. Improved coverage also directly helps #61, #63, #40
It reorganizes the suite so coverage is easier to reason about and maintain. The old monolithic test/runtests.jl is now split into feature-focused files for special-function helpers, broad algorithm sweeps, confluent-function coverage, and regression/boundary tests. That makes it much easier to see what behavior each block is protecting and to add issue-driven tests without burying them in a giant file.
It adds targeted high-signal tests around behavior that was previously thinly covered. In particular: