Skip to content

Show the metadata tags in the flamegraph UI by default#91

Open
NHDaly wants to merge 14 commits into
mainfrom
nhd-tags-flamegraph
Open

Show the metadata tags in the flamegraph UI by default#91
NHDaly wants to merge 14 commits into
mainfrom
nhd-tags-flamegraph

Conversation

@NHDaly

@NHDaly NHDaly commented Oct 20, 2023

Copy link
Copy Markdown
Member

Add an option to show the metadata tags in the flamegraph view, as root nodes, like this:
Screenshot 2023-10-20 at 4 57 49 PM

I don't love that the tags aren't labelled..... I've asked about that here:
google/pprof#811

I'm also not sure if tagroot= is the right way to expose this. Maybe it should be higher-level, like metadata::Bool and we just add this? Or groupby=["taskid", "threadid"], and we turn that into tagroots?

@NHDaly NHDaly requested a review from vchuravy October 20, 2023 22:59
@codecov

codecov Bot commented Oct 21, 2023

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.43590% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 96.01%. Comparing base (6e9f56c) to head (c2ec74d).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
src/PProf.jl 97.43% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
- Coverage   96.66%   96.01%   -0.66%     
==========================================
  Files           3        3              
  Lines         300      326      +26     
==========================================
+ Hits          290      313      +23     
- Misses         10       13       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@NHDaly NHDaly force-pushed the nhd-tags-flamegraph branch from c0399b8 to c2ec74d Compare October 21, 2023 03:25
Base automatically changed from vc/tags to main November 16, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants