Repository navigation
Declare Julia floor 1.10, bound Statistics, and test the floor in CI - #16
Merged
Merged
Conversation
…loor in CI Completes the compat cleanup started in #15. The declared `julia = "1.6"` lower bound was never achievable: SMLMData 0.7 requires Julia >= 1.9, and the current releases of Optim 2.x, NearestNeighbors 0.4.26+, and StatsBase 0.34.5+ all require Julia >= 1.10. Julia 1.9 would only resolve against years-old dependency releases that have never been tested here, so the floor is set to 1.10 (the current LTS, and the version SMLMAnalysis pins and tests). Because no released 0.3.x ever installed below Julia 1.12, raising the floor drops no working configuration, so the version stays at the unregistered 0.3.4. Statistics gets an explicit `"1"` compat entry so a future breaking Statistics 2 cannot be picked up silently (it is an upgradable stdlib on Julia 1.11+). AutoMerge exempts stdlibs, so this is hygiene rather than a registration requirement. CI now runs the 1.10 floor alongside `1` and `nightly`, so the declared lower bound is an exercised claim rather than an aspiration. The untested floor is what let the LinearAlgebra pin survive four releases. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Follow-up to #15, completing the compat cleanup so 0.3.4 declares accurate version requirements before registration.
julia = "1.6"was never achievable. SMLMData 0.7 requires Julia ≥ 1.9, and the current releases of Optim 2.x, NearestNeighbors 0.4.26+, and StatsBase 0.34.5+ all require Julia ≥ 1.10. Julia 1.9 would only resolve against years-old dependency releases that have never been tested with this package.Statisticshad no compat entry, so a future breaking Statistics 2 could be picked up silently (it is an upgradable stdlib on Julia 1.11+).1andnightly, so the declared floor was never exercised. That gap is what let theLinearAlgebra = "1.12.0"pin survive four releases.Fix
julia = "1.6"→julia = "1.10"(current LTS; matches what SMLMAnalysis pins and tests)Statistics = "1"to[compat]'1.10'to the CI matrix alongside'1'and'nightly'Version stays at the unregistered 0.3.4: no released 0.3.x ever installed below Julia 1.12, so raising the declared floor drops no working configuration.
Tests
Full
Pkg.test()on this branch:Do not register from this PR without review. Once merged, 0.3.4 is ready for JuliaRegistrator; SMLMAnalysis will then pin
SMLMFrameConnection = "0.3.4".🤖 Generated with Claude Code