Stop worker processes even when finalization rethrows a task failure - #160
Draft
giordano wants to merge 3 commits into
Draft
Stop worker processes even when finalization rethrows a task failure#160giordano wants to merge 3 commits into
giordano wants to merge 3 commits into
Conversation
Finalization waited on the printer task and the worker tasks — rethrowing any non-interrupt failure (e.g. a throwing `test_worker` hook) — before stopping the workers left in the pool, so a propagated failure leaked live worker processes for the rest of the parent session. A failure during a serial phase additionally stranded the shared serial worker in its Ref, which even the pool cleanup would have missed, since returning it to the pool is skipped when the phase's `@sync` throws. Run the worker cleanup in a `finally` block and also stop a stranded serial worker there. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Collaborator
Author
|
#158 and #159 were relatively simple and hopefully uncontroversial, this one is more convoluted and probably warrants a more careful review (ignoring whitespace changes helps). At least I verified that the newly added tests fail on |
giordano
marked this pull request as draft
August 8, 2026 23:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.