chore(renderer): tidy the comments and test hook noted in the pane isolation review - #828
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013SULm3ApxebET2a8eLxKHd
…olation review The #810 review left three non-blocking notes: a comment naming a renamed function, an invariant sentence that read badly, and a regression test that detected the running state through a Tailwind class. The test now reads a data attribute computed from the same branches as the color, so styling changes cannot break it and the attribute cannot drift from the color. Refs #763 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013SULm3ApxebET2a8eLxKHd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Review B of #810 left three non-blocking notes that were never actioned: a WHY comment in
selectionStash.tsstill namedsetDraftVersion(renamed tobumpDraftChangesin #810), the newEMPTY_RUNTIMEinvariant comment ended in a sentence that read badly, and the newPaneHeader.phoneCouplingtest detected the running state through a.bg-accentclass query.Change
data-related-status="error|attention|running|idle"computed from the same branches as its color; the test queries that attribute.Verification
PaneHeader.phoneCoupling.renderer.test.tsx: 3 tests pass on Node 24.npm run typecheckclean.Refs #763
🤖 Generated with Claude Code
https://claude.ai/code/session_013SULm3ApxebET2a8eLxKHd