Refactor the converter table in Texture2DConverter#321
Merged
K0lb3 merged 2 commits intoK0lb3:masterfrom May 31, 2025
Merged
Conversation
bf4d4a4 to
cd72704
Compare
cd72704 to
f02429d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the
CONV_TABLEand it related code.{ TF -> (function, arg1, arg2, ...) }{ TF -> (function, (arg1, arg2, ...)) }This PR also:
CONV_TABLEwhereEAC_R:SIGNEDshould beEAC_R_SIGNED.fmtargument ofetcfunction to maintain consistency witheac.Rationality
Clearly separate function and its additional arguments.
Resolves
typing_extensionsimport error.In 035cb09 ,
typing_extensionspackage has been introduced toTexture2DConverterto provide theUnpacktype hint. However, this package is not a standard library, so it is not installed in some Python environments, causingModuleNotFoundError. Adding this package to UnityPy's dependencies explicitly can solve this error, but it is not worth it.