Skip to content

Fix install on Windows, modernize CI, add Claude integration - #2

Open
mrustl wants to merge 1 commit into
devfrom
fix/gh-actions-claude-encoding
Open

mrustl wants to merge 1 commit into
devfrom
fix/gh-actions-claude-encoding

Conversation

@mrustl

@mrustl mrustl commented May 23, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Installation fix: remotes::install_github("kwb-r/qsimVis@dev") failed on Windows with input string 416 is invalid because of 9 verknet CSVs with German umlauts. Renamed to ASCII equivalents (Oe / Ue / Ae). qsimVis_ID columns in impetus/ mapping tables updated to match new filenames; model_IDs left unchanged to preserve compat with external QSim output.
  • GH Actions modernized to align with KWB-R/kwb.pkgbuild style: actions/checkout@v5, r-lib/actions/setup-r-dependencies@v2 + check-r-package@v2, codecov-action@v5, JamesIves/github-pages-deploy-action@v4.7.3.
  • Claude integration: added claude.yaml (responds to @claude mentions in issues/PRs) and claude-code-review.yaml (auto-reviews PRs), both from kwb.pkgbuild.

Action required

Set the CLAUDE_CODE_OAUTH_TOKEN repository secret in GitHub Actions settings — without it the two Claude workflows will fail at runtime.

Test plan

  • CI passes on this PR (R-CMD-check across mac/ubuntu/windows x release/devel/oldrel)
  • After merge to dev, verify remotes::install_github("kwb-r/qsimVis@dev") succeeds on Windows
  • Configure CLAUDE_CODE_OAUTH_TOKEN secret and verify @claude mention triggers the workflow

Generated with Claude Code

Resolves "input string 416 is invalid" error from
remotes::install_github("kwb-r/qsimVis@dev") on Windows by replacing
non-ASCII (umlaut) filenames in inst/extdata/verknet/ with ASCII
equivalents (Oe/Ue/Ae/oe/ue). qsimVis_ID columns in impetus
mapping tables updated to match new filenames; model_IDs left
unchanged to preserve compatibility with external simulation output.

Workflows aligned to KWB-R/kwb.pkgbuild style: actions/checkout@v5,
r-lib/actions/setup-r-dependencies@v2, codecov-action@v5,
JamesIves/github-pages-deploy-action@v4.7.3.

Adds claude.yaml and claude-code-review.yaml from kwb.pkgbuild
(requires CLAUDE_CODE_OAUTH_TOKEN secret to be set in repo settings).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@mrustl
mrustl requested a review from ma-z-am May 23, 2026 10:22
@mrustl

mrustl commented May 23, 2026

Copy link
Copy Markdown
Member Author

remotes::install_github("kwb-r/qsimVis@fix/gh-actions-claude-encoding") runs successfully!

@daniel-wicke

Copy link
Copy Markdown
Contributor

Hey @ma-z-am könnstest du mal prüfen ob du den Pull Request auf dev mergen kannst? Unter R 4.6.1:

> remotes::install_github("kwb-r/qSimVis")
Using github PAT from envvar GITHUB_PAT. Use `gitcreds::gitcreds_set()` and unset GITHUB_PAT in .Renviron (or elsewhere) if you want to use the more secure git credential store instead.
Downloading GitHub repo kwb-r/qSimVis@HEAD
Fehler: Failed to install 'qsimVis' from GitHub:
  input string 407 is invalid
Zusätzlich: Warnmeldung:
In gsub("[^/]", "", file_list) :
  unable to translate 'KWB-R-qsimVis-05ff784/inst/extdata/verknet/F+<fb>H.csv' to a wide string

Fixed:

> remotes::install_github("kwb-r/qSimVis@fix/gh-actions-claude-encoding")
Using github PAT from envvar GITHUB_PAT. Use `gitcreds::gitcreds_set()` and unset GITHUB_PAT in .Renviron (or elsewhere) if you want to use the more secure git credential store instead.
Downloading GitHub repo kwb-r/qSimVis@fix/gh-actions-claude-encoding
Installing 12 packages: sys, askpass, openssl, curl, httr, bitops, jpeg, plyr, png, ggmap, geosphere, data.table
Installiere Pakete nach ‘C:/Users/dwicke/AppData/Local/R/win-library/4.6’
(da ‘lib’ nicht spezifiziert)
versuche URL 'https://packagemanager.rstudio.com/all/__linux__/focal/latest/bin/windows/contrib/4.6/sys_3.4.3.zip'
versuche URL 'https://packagemanager.rstudio.com/all/__linux__/focal/latest/bin/windows/contrib/4.6/askpass_1.2.1.zip'
versuche URL 'https://packagemanager.rstudio.com/all/__linux__/focal/latest/bin/windows/contrib/4.6/openssl_2.4.2.zip'
versuche URL 'https://packagemanager.rstudio.com/all/__linux__/focal/latest/bin/windows/contrib/4.6/curl_8.0.0.zip'
versuche URL 'https://packagemanager.rstudio.com/all/__linux__/focal/latest/bin/windows/contrib/4.6/httr_1.4.9.zip'
versuche URL 'https://packagemanager.rstudio.com/all/__linux__/focal/latest/bin/windows/contrib/4.6/bitops_1.1-0.zip'
versuche URL 'https://packagemanager.rstudio.com/all/__linux__/focal/latest/bin/windows/contrib/4.6/jpeg_0.1-11.zip'
versuche URL 'https://packagemanager.rstudio.com/all/__linux__/focal/latest/bin/windows/contrib/4.6/plyr_1.8.9.zip'
versuche URL 'https://packagemanager.rstudio.com/all/__linux__/focal/latest/bin/windows/contrib/4.6/png_0.1-9.zip'
versuche URL 'https://packagemanager.rstudio.com/all/__linux__/focal/latest/bin/windows/contrib/4.6/ggmap_4.0.2.zip'
versuche URL 'https://packagemanager.rstudio.com/all/__linux__/focal/latest/bin/windows/contrib/4.6/geosphere_1.6-8.zip'
versuche URL 'https://packagemanager.rstudio.com/all/__linux__/focal/latest/bin/windows/contrib/4.6/data.table_1.18.6.1.zip'
package ‘sys’ successfully unpacked and MD5 sums checked
package ‘askpass’ successfully unpacked and MD5 sums checked
package ‘openssl’ successfully unpacked and MD5 sums checked
package ‘curl’ successfully unpacked and MD5 sums checked
package ‘httr’ successfully unpacked and MD5 sums checked
package ‘bitops’ successfully unpacked and MD5 sums checked
package ‘jpeg’ successfully unpacked and MD5 sums checked
package ‘plyr’ successfully unpacked and MD5 sums checked
package ‘png’ successfully unpacked and MD5 sums checked
package ‘ggmap’ successfully unpacked and MD5 sums checked
package ‘geosphere’ successfully unpacked and MD5 sums checked
package ‘data.table’ successfully unpacked and MD5 sums checked

Die heruntergeladenen Binärpakete sind in 
	C:\Users\dwicke\AppData\Local\Temp\RtmpmoCUtG\downloaded_packages
── R CMD build ───────────────────────────────────────────────────────────────────────────────────────────────────────────────────
✔  checking for file 'C:\Users\dwicke\AppData\Local\Temp\RtmpmoCUtG\remotes3420625426f4\KWB-R-qsimVis-fa14754/DESCRIPTION' (570ms)
─  preparing 'qsimVis': (2s)
✔  checking DESCRIPTION meta-information ...
─  checking for LF line-endings in source and make files and shell scripts (519ms)
─  checking for empty or unneeded directories
─  building 'qsimVis_0.0.0.9000.tar.gz' (488ms)
   
Installiere Paket nach ‘C:/Users/dwicke/AppData/Local/R/win-library/4.6’
(da ‘lib’ nicht spezifiziert)
* installing *source* package 'qsimVis' ...
** this is package 'qsimVis' version '0.0.0.9000'
** using staged installation
** R
** data
*** moving datasets to lazyload DB
** inst
** byte-compile and prepare package for lazy loading
** help
*** installing help indices
** building package indices
** testing if installed package can be loaded from temporary location
** testing if installed package can be loaded from final location
** testing if installed package keeps a record of temporary installation path
* DONE (qsimVis)

Dank dir by @mrustl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants