feat: add reusable Button component with variant support#289
Open
ryzen-xp wants to merge 1 commit into
Open
Conversation
Contributor
|
Hello sir, it looks nice but I need you to add a default padding value, specifically ps-5 pe-5 pt-2 pb-2 and add image evidences with this change. Then I can merge it. |
7 tasks
Contributor
|
@ryzen-xp hello sir, any updates on this? If we don't get updates on this to tomorrow morning we'll reassign it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 feat: Create reusable Button component with variant support
🛠️ Issue
📖 Description
Buttoncomponent atfrontend/components/ui/button.tsx.✅ Changes made
frontend/components/ui/button.tsxconforming exactly to the requested props:label: string(rendered text)variant: 'primary' | 'ghost' | 'danger'disabled?: boolean(handles opacity and interactive safety)onClick: () => voidclass-variance-authority(cva) andclsx/tailwind-mergefor robust custom class combination.rounded-full) matching the design specifications.active:scale-97), smooth opacity transitions for hover actions, and focus ring outlines for improved accessibility.🖼️ Media (screenshots/videos)
📜 Additional Notes
pnpm build.pnpm lint) to guarantee the file contains zero warnings or format errors.