Skip to content

Maintenance fixes#202

Merged
artiomn merged 30 commits into
KasperskyLab:masterfrom
buligar:feature/mnist-network-visualization
Jul 9, 2026
Merged

Maintenance fixes#202
artiomn merged 30 commits into
KasperskyLab:masterfrom
buligar:feature/mnist-network-visualization

Conversation

@buligar

@buligar buligar commented Jun 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Removes the MNIST visualization changes from this PR.

Remaining changes include:

  • CI/Docker build workflow updates.
  • UUID byte handling and regression coverage.
  • Backend loader lifetime and connectivity export fixes.
  • Small MNIST example fixes unrelated to visualization.

buligar and others added 20 commits April 8, 2026 16:23
@buligar
fix(python): validate UUID byte length in Boost.Python converter
b04ca86 
Reject Python UUID objects with invalid byte length before copying into boost::uuids::uuid and raise ValueError instead of performing unchecked memory access.

Add a regression test for malformed UUID bytes in Python bindings.
@buligar
fix(framework): keep backend creators alive
62373f7
@buligar
fix(examples): make mnist client portable
90e9007
@buligar
fix(python): read UUID bytes in converter
b75b7a9
@buligar
Merge remote-tracking branch 'upstream/master' into fix/issue-175-uui…
1b46947 
…d-validation
@buligar
ci: fallback Docker Hub namespace for build image
01fc3d4
@buligar
ci: build SDK image from generated packages
52b7908
@buligar
Merge branch 'master' into fix/issue-175-uuid-validation
e75dae8
@buligar
Merge branch 'master' into fix/issue-175-uuid-validation
efac703
@buligar
ci: remove duplicate SDK image build keys
18369a2
@buligar
ci: skip Docker Hub login without token
bbab176
@buligar
Add neuron-level MNIST network visualization
3698ca0
@buligar
Fix macOS Boost install in CI
3484598
@buligar
Fix neuron visualization build with clang
5ace43a
@buligar
Install OpenCV for macOS CI
7a53b28
@buligar
Skip Docker Hub publish on PR builds
aa1cc83
@buligar
Avoid Docker Hub login on PR image builds
0b5b119
@buligar
Fix AltAI quantization max type deduction
41e276a
@buligar
Use vcpkg toolchain for Windows OpenCV CI
7ed6beb
@buligar
Export connectivity validator API
022721b
@buligar

buligar commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

Added validate UUID byte length and population network visualization MNIST-client

artiomn
artiomn requested changes Jun 23, 2026
View reviewed changes

@artiomn artiomn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Смотрится не очень наглядно, судя по картинке.
  2. В один реквест не стоит вносить разные изменения.
  3. Крупную функциональность лучше обговаривать: предварительно написать и заплланировать созвон.

Comment thread .github/workflows/cmake-build.yml Outdated
Comment thread .github/workflows/docker-build-image.yml Outdated
Comment thread docker/sdk-image/Dockerfile Outdated
Comment thread examples/mnist-client/inference.cpp Outdated
Comment thread examples/mnist-client/main.cpp Outdated
Comment thread knp/base-framework/impl/visualizer/visualize_network.cpp Outdated
Comment thread knp/base-framework/impl/visualizer/visualize_network.cpp Outdated
Comment thread knp/base-framework/impl/visualizer/visualize_network.cpp Outdated
Comment thread knp/base-framework/impl/backend_loader.cpp Outdated
Comment thread knp/python-framework/impl/core/cpp/uid_utilities.h
@buligar buligar mentioned this pull request Jun 24, 2026
Closed
@buligar buligar changed the title Feature/mnist network visualization Maintenance fixes Jun 24, 2026
artiomn
artiomn requested changes Jun 26, 2026
View reviewed changes
Comment thread .github/workflows/docker-build-image.yml Outdated
Comment thread .github/workflows/docker-build-image.yml
Comment thread .github/workflows/docker-build-image.yml Outdated
Comment thread .github/workflows/docker-build-image.yml Outdated
Comment thread .github/workflows/cmake-build.yml Outdated
Comment thread .github/workflows/cmake-build.yml Outdated
Comment thread .github/workflows/cmake-build.yml Outdated
Comment thread .github/workflows/docker-build-image.yml Outdated
Comment thread knp/base-framework/include/knp/framework/network_validation/executor.h Outdated
Comment thread knp/python-framework/tests/unit/core/test_uid.py Outdated
artiomn
artiomn requested changes Jun 30, 2026
View reviewed changes
Comment thread .github/workflows/docker-build-image.yml
Comment thread .github/workflows/docker-build-image.yml
@buligar

buligar commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

Когда запускаю текущий docker выдает ошибку
Run docker run --platform=linux/amd64 --rm -v /home/runner/work/knp/knp:/KNP -w /KNP /knp-build-image:latest cmake --build build_gcc --parallel 8
docker: invalid reference format

Run 'docker run --help' for more information
Error: Process completed with exit code 125.

artiomn
artiomn requested changes Jul 1, 2026
View reviewed changes
Comment thread examples/mnist-client/inference.cpp Outdated
Comment thread examples/mnist-learn/models/altai/prepare_network_for_inference.cpp Outdated
Comment thread examples/mnist-learn/models/altai/prepare_network_for_inference.cpp Outdated
Comment thread knp/base-framework/impl/backend_loader.cpp Outdated
Comment thread knp/base-framework/impl/backend_loader.cpp Outdated
buligar and others added 2 commits July 6, 2026 13:35
@buligar @claude
Address review comments: revert off-topic changes, fix author tag
4496058 
- Revert lambda capture and filesystem::path changes in mnist-client inference.cpp.
- Revert abs() replacement in prepare_network_for_inference.cpp.
- Revert backend_loader lifetime changes (to be solved differently in a separate task).
- Set proper @author tag in test_uid.py and drop incorrect kaspersky_support line.
- Add explicit <string> include used by std::to_string in uid_utilities.h.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@buligar
Update author name in test_uid.py
f110bdb
@artiomn

artiomn commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Когда запускаю текущий docker выдает ошибку Run docker run --platform=linux/amd64 --rm -v /home/runner/work/knp/knp:/KNP -w /KNP /knp-build-image:latest cmake --build build_gcc --parallel 8 docker: invalid reference format

Run 'docker run --help' for more information Error: Process completed with exit code 125.

Не сразу увидел.
Проблема в слэше: /.
Надо так: docker run --platform=linux/amd64 --rm -v /home/runner/work/knp/knp:/KNP -w /KNP knp-build-image:latest cmake --build build_gcc --parallel 8

@artiomn
artiomn merged commit 70208e9 into KasperskyLab:master Jul 9, 2026
3 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artiomn artiomn artiomn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@buligar @artiomn