[PR] fix(dataproc): only create output artifacts for the selected output mode - #136
Merged
Merged
Conversation
all_replays.json, package_N.zip, and package_summary_N.json were each being created unconditionally, regardless of whether -single_json_output or zip packaging was actually selected. Gate the single-JSON writer goroutine on cliFlags.SingleJsonOutput, and gate zip-writer init/save/finalize on a new writeZipPackage flag (packageToZipBool && !cliFlags.SingleJsonOutput), so only the artifacts for the chosen mode get written. Also add SetDefaultLogging(), a basic stdout logger active before SetLogging can run (i.e. while flags are still being parsed), so failures during flag parsing are visible instead of relying on logrus's uninitialized zero-value default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
all_replays.json, package_N.zip, and package_summary_N.json were each being created unconditionally, regardless of whether -single_json_output or zip packaging was actually selected. Gate the single-JSON writer goroutine on cliFlags.SingleJsonOutput, and gate zip-writer init/save/finalize on a new writeZipPackage flag
(packageToZipBool && !cliFlags.SingleJsonOutput), so only the artifacts for the chosen mode get written.
Also add SetDefaultLogging(), a basic stdout logger active before SetLogging can run (i.e. while flags are still being parsed), so failures during flag parsing are visible instead of relying on logrus's uninitialized zero-value default.